Skip to content

BLD/TST: cross compat for pa/fp failing on osx & windows #18715

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Dec 10, 2017

xref #18662
closes #18714

@jreback jreback added IO Parquet parquet, feather Testing pandas testing functions or related to the test suite labels Dec 10, 2017
@jreback jreback added this to the 0.21.1 milestone Dec 10, 2017
@jreback
Copy link
Contributor Author

jreback commented Dec 10, 2017

this is not great because xfailing entire test. should figure out what actually is failing and only xfail that part.

@jreback
Copy link
Contributor Author

jreback commented Dec 10, 2017

I think fastparquet is using deps which cause an upgrade of numpy here.

package plan for installation in environment /Users/travis/miniconda3/envs/pandas:
The following NEW packages will be INSTALLED:
    arrow-cpp:      0.7.1-py35_2               conda-forge
    fastparquet:    0.1.3-py35_0               conda-forge
    feather-format: 0.3.1-py35_1               conda-forge
    llvmlite:       0.21.0-py35h3a66efe_0                 
    numba:          0.36.1-np113py35hd65e1c9_0            
    parquet-cpp:    1.3.0.post-2               conda-forge
    pyarrow:        0.7.1-py35_1               conda-forge
    thrift:         0.10.0-py35_0              conda-forge
The following packages will be UPDATED:
    numpy:          1.10.4-py35_nomkl_2                    [nomkl] --> 1.13.3-py35_nomklh6554414_0 [nomkl]

So easiest is to simply use a later version of numpy on this build. I will update.

@jreback jreback force-pushed the fix branch 2 times, most recently from af81c40 to e5fda12 Compare December 10, 2017 17:37
@TomAugspurger TomAugspurger mentioned this pull request Dec 11, 2017
58 tasks
@TomAugspurger
Copy link
Contributor

I think this will fail until fastparquet does a release with dask/fastparquet#264

@jreback
Copy link
Contributor Author

jreback commented Dec 12, 2017

yeah, going to move to 0.22.0

@jreback jreback modified the milestones: 0.21.1, 0.22.0 Dec 12, 2017
@jreback jreback mentioned this pull request Dec 13, 2017
4 tasks
@codecov
Copy link

codecov bot commented Dec 18, 2017

Codecov Report

Merging #18715 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18715      +/-   ##
==========================================
- Coverage   91.64%   91.57%   -0.08%     
==========================================
  Files         154      153       -1     
  Lines       51430    51307     -123     
==========================================
- Hits        47131    46982     -149     
- Misses       4299     4325      +26
Flag Coverage Δ
#multiple 89.43% <ø> (-0.06%) ⬇️
#single 40.71% <ø> (-0.24%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 64.78% <0%> (-1.74%) ⬇️
pandas/util/_test_decorators.py 93.33% <0%> (-1.22%) ⬇️
pandas/core/reshape/melt.py 96.22% <0%> (-1.03%) ⬇️
pandas/util/testing.py 82.01% <0%> (-0.9%) ⬇️
pandas/core/indexes/category.py 97.2% <0%> (-0.31%) ⬇️
pandas/core/categorical.py 95.64% <0%> (-0.15%) ⬇️
pandas/io/formats/format.py 96.03% <0%> (-0.15%) ⬇️
pandas/core/dtypes/dtypes.py 95.14% <0%> (-0.14%) ⬇️
pandas/core/indexes/numeric.py 97.26% <0%> (-0.11%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f1e71...741ff7f. Read the comment docs.

@jreback
Copy link
Contributor Author

jreback commented Dec 18, 2017

I blew this away accid, so closing for now.

@jreback jreback closed this Dec 18, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
IO Parquet parquet, feather Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLD/TST: add pyarrow on CI to macosx build
2 participants