-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BLD/TST: cross compat for pa/fp failing on osx & windows #18715
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
this is not great because xfailing entire test. should figure out what actually is failing and only xfail that part. |
I think fastparquet is using deps which cause an upgrade of numpy here.
So easiest is to simply use a later version of numpy on this build. I will update. |
af81c40
to
e5fda12
Compare
I think this will fail until fastparquet does a release with dask/fastparquet#264 |
yeah, going to move to 0.22.0 |
Codecov Report
@@ Coverage Diff @@
## master #18715 +/- ##
==========================================
- Coverage 91.64% 91.57% -0.08%
==========================================
Files 154 153 -1
Lines 51430 51307 -123
==========================================
- Hits 47131 46982 -149
- Misses 4299 4325 +26
Continue to review full report at Codecov.
|
I blew this away accid, so closing for now. |
xref #18662
closes #18714