-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DOC: removed vendored IPython.sphinxext - take 2 #19657
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DOC: removed vendored IPython.sphinxext - take 2 #19657
Conversation
…)" (pandas-dev#18320)" This reverts commit d6049a0.
@TomAugspurger We were actually a bit fast, the fix of ipython/ipython#10907 is actually not yet in a released version. |
Codecov Report
@@ Coverage Diff @@
## master #19657 +/- ##
==========================================
- Coverage 91.84% 91.81% -0.03%
==========================================
Files 153 153
Lines 49265 49265
==========================================
- Hits 45245 45235 -10
- Misses 4020 4030 +10
Continue to review full report at Codecov.
|
Oh, I thought the backported in
ipython/ipython#10908 was released, but apparently
not yet.
…On Mon, Feb 12, 2018 at 12:33 PM, Joris Van den Bossche < ***@***.***> wrote:
@TomAugspurger <https://github.com/tomaugspurger> We were actually a bit
fast, the fix of ipython/ipython#10907
<ipython/ipython#10907> is actually not yet in a
released version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19657 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIt266I9KH2INAdB3t5VjYqudItDOks5tUIPcgaJpZM4SCH3g>
.
|
this looks fine. @jorisvandenbossche merge when ready. |
Don't merge, we need to wait until the next IPython release .. |
status @jorisvandenbossche ? |
This needs to wait until IPython has a new release. If you rather close the PR until then, that's fine for me as well (having it open is a reminder for me, but can also open an issue) |
it’s fine - |
IPython has released, update the PR, and this seems to be working now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only thing I would say is bump ci/requirements-optional-conda.txt
to require at least 6.3.1?
This reverts commit d6049a0.
xref #18147, re-do #18193 (which was reverted in #18320 because there was still a bug in IPython, which is now fixed in the released version: ipython/ipython#10907)