Skip to content

DOC: removed vendored IPython.sphinxext - take 2 #19657

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

This reverts commit d6049a0.

xref #18147, re-do #18193 (which was reverted in #18320 because there was still a bug in IPython, which is now fixed in the released version: ipython/ipython#10907)

@TomAugspurger TomAugspurger mentioned this pull request Feb 12, 2018
15 tasks
@jorisvandenbossche
Copy link
Member Author

@TomAugspurger We were actually a bit fast, the fix of ipython/ipython#10907 is actually not yet in a released version.

@codecov
Copy link

codecov bot commented Feb 12, 2018

Codecov Report

Merging #19657 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19657      +/-   ##
==========================================
- Coverage   91.84%   91.81%   -0.03%     
==========================================
  Files         153      153              
  Lines       49265    49265              
==========================================
- Hits        45245    45235      -10     
- Misses       4020     4030      +10
Flag Coverage Δ
#multiple 90.2% <ø> (-0.03%) ⬇️
#single 41.9% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.07% <0%> (-1.74%) ⬇️
pandas/util/testing.py 84.73% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2431641...8ec7f4b. Read the comment docs.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Feb 12, 2018 via email

@jreback jreback added the Docs label Feb 14, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 14, 2018
@jreback
Copy link
Contributor

jreback commented Feb 14, 2018

this looks fine. @jorisvandenbossche merge when ready.

@jorisvandenbossche
Copy link
Member Author

Don't merge, we need to wait until the next IPython release ..

@jreback
Copy link
Contributor

jreback commented Mar 16, 2018

status @jorisvandenbossche ?

@jorisvandenbossche
Copy link
Member Author

This needs to wait until IPython has a new release. If you rather close the PR until then, that's fine for me as well (having it open is a reminder for me, but can also open an issue)

@jreback
Copy link
Contributor

jreback commented Mar 16, 2018

it’s fine -

@jorisvandenbossche jorisvandenbossche removed this from the 0.23.0 milestone Mar 29, 2018
@jorisvandenbossche
Copy link
Member Author

IPython has released, update the PR, and this seems to be working now

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only thing I would say is bump ci/requirements-optional-conda.txt to require at least 6.3.1?

@jorisvandenbossche jorisvandenbossche merged commit a80c783 into pandas-dev:master Apr 23, 2018
@jorisvandenbossche jorisvandenbossche deleted the remove-ipython branch April 23, 2018 13:59
@jorisvandenbossche jorisvandenbossche added this to the 0.23.0 milestone Apr 23, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants