BUG: fixed json_normalize for subrecords with NoneTypes (#20030) #20399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TST: additional coverage for the test cases DOC: added changes to whatsnew/v0.23.0.txt BUG: changed how nan is declared for backward compatibility - python2.7
Codecov Report
@@ Coverage Diff @@
## master #20399 +/- ##
==========================================
+ Coverage 91.77% 91.77% +<.01%
==========================================
Files 152 152
Lines 49205 49215 +10
==========================================
+ Hits 45159 45169 +10
Misses 4046 4046
Continue to review full report at Codecov.
|
jreback
requested changes
Mar 20, 2018
| @@ -226,6 +237,21 @@ def test_non_ascii_key(self): | |||
| result = json_normalize(json.loads(testjson)) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_missing_field(self, author_missing_data): | |||
| result = json_normalize(author_missing_data) | |||
There was a problem hiding this comment.
can you add the issue number as a comment. & a 1-liner explaining the test purpose
| @@ -322,3 +348,26 @@ def test_json_normalize_errors(self): | |||
| ['general', 'trade_version']], | |||
| errors='raise' | |||
| ) | |||
|
|
|||
| def test_nonetype_dropping(self): | |||
| data = [ | |||
There was a problem hiding this comment.
same, pls add the gh issue number as a comment and 1 liner
| def test_missing_field(self, author_missing_data): | ||
| result = json_normalize(author_missing_data) | ||
| ex_data = [ | ||
| {'author_name.first': float('nan'), |
jreback
added
Missing-data
|
@jreback I have updated the PR, let me know if you need me to squash the changes instead. |
jreback
approved these changes
Mar 20, 2018
|
thanks @aerymilts nice patch! keep em coming! |
nehiljain
added a commit
to nehiljain/pandas
that referenced
this pull request
Mar 21, 2018
…ame_describe * upstream/master: (158 commits) Add link to "Craft Minimal Bug Report" blogpost (pandas-dev#20431) BUG: fixed json_normalize for subrecords with NoneTypes (pandas-dev#20030) (pandas-dev#20399) BUG: ExtensionArray.fillna for scalar values (pandas-dev#20412) DOC" update the Pandas core window rolling count docstring" (pandas-dev#20264) DOC: update the pandas.DataFrame.plot.hist docstring (pandas-dev#20155) DOC: Only use ~ in class links to hide prefixes. (pandas-dev#20402) Bug: Allow np.timedelta64 objects to index TimedeltaIndex (pandas-dev#20408) DOC: add disallowing of Series construction of len-1 list with index to whatsnew (pandas-dev#20392) MAINT: Remove weird pd file DOC: update the Index.isin docstring (pandas-dev#20249) BUG: Handle all-NA blocks in concat (pandas-dev#20382) DOC: update the pandas.core.resample.Resampler.fillna docstring (pandas-dev#20379) BUG: Don't raise exceptions splitting a blank string (pandas-dev#20067) DOC: update the pandas.DataFrame.cummax docstring (pandas-dev#20336) DOC: update the pandas.core.window.x.mean docstring (pandas-dev#20265) DOC: update the api.types.is_number docstring (pandas-dev#20196) Fix linter (pandas-dev#20389) DOC: Improved the docstring of pandas.Series.dt.to_pytimedelta (pandas-dev#20142) DOC: update the pandas.Series.dt.is_month_end docstring (pandas-dev#20181) DOC: update the window.Rolling.min docstring (pandas-dev#20263) ...
dworvos
pushed a commit
to dworvos/pandas
that referenced
this pull request
Apr 2, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TST: additional coverage for the test cases
DOC: added changes to whatsnew/v0.23.0.txt
Checklist for other PRs (remove this part if you are doing a PR for the pandas documentation sprint):
git diff upstream/master -u -- "*.py" | flake8 --diff