Skip to content

BUG: .cat changing dtype inplace #43597

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2021
Merged

BUG: .cat changing dtype inplace #43597

merged 3 commits into from
Sep 17, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Sep 16, 2021 •
edited
Loading

@jreback jreback added this to the 1.3.4 milestone Sep 16, 2021
@jreback jreback added Bug Categorical Categorical Data Type labels Sep 16, 2021
jreback
jreback requested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew for 1.3.4

@jreback jreback merged commit 26064f0 into pandas-dev:master Sep 17, 2021
@jreback
Copy link
Contributor

jreback commented Sep 17, 2021

@meeseeksdev backport 1.3.x

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 17, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 17, 2021
@jbrockmendel @meeseeksmachine
Backport PR pandas-dev#43597: BUG: .cat changing dtype inplace
cee3583
@lumberbot-app

This comment has been minimized.

# to view
@jbrockmendel jbrockmendel deleted the regr-cat branch September 17, 2021 18:16
jreback added a commit that referenced this pull request Sep 18, 2021
@meeseeksmachine @jbrockmendel @jreback
Backport PR #43597: BUG: .cat changing dtype inplace (#43622)
2b41d7b 
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
Co-authored-by: Jeff Reback <jeff@reback.net>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Categorical Categorical Data Type
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.

BUG: pd.Categorical turns all values into NaN BUG: reorder_categories with inplace=True is not changing the dtype.categories
3 participants
@jbrockmendel @jreback @simonjayhawkins