DEP: Deprecate passing a DataFrame to from_records #51697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/frame.py
Outdated
| if isinstance(data, DataFrame): | ||
| warnings.warn( | ||
| "Passing a DataFrame to DataFrame.from_records is deprecated. Use " | ||
| "set_index and/or drop instead to modify the DataFrame.", |
There was a problem hiding this comment.
Why I am using instead or placement of instead within the sentence?
There was a problem hiding this comment.
im suggesting adding "instead" at the end of the last sentence
phofl
added
Deprecate
|
small comment, otherwise LGTM |
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jbrockmendel as discussed, restructuring this allows us to simplify to_arrays immediately