-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DEPR: observed=False default in groupby #51811
Conversation
for users who work interaactively (ipython, jupyter,..), Is there way to avoid the Otherwise LGTM. |
Thanks @topper-123
Users can specify I think you're thinking of some global option? I would be -1 on that, and hope this will be rare enough that it won't pester users. They'll need to specify |
doc/source/whatsnew/v2.1.0.rst
Outdated
@@ -93,10 +93,10 @@ Other API changes | |||
Deprecations | |||
~~~~~~~~~~~~ | |||
- Deprecating pinning ``group.name`` to each group in :meth:`SeriesGroupBy.aggregate` aggregations; if your operation requires utilizing the groupby keys, iterate over the groupby object instead (:issue:`41090`) | |||
- Deprecated the default of ``observed=False`` in :meth:`DataFrame.groupby` and :meth:`Series.groupby` (:issue:`43999`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mention this will be True
in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call - done.
…into depr_observed # Conflicts: # pandas/tests/groupby/test_categorical.py
…_observed # Conflicts: # doc/source/whatsnew/v2.1.0.rst
Thanks @rhshadrach |
observed=True
inDataFrame.groupby
#43999 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.