DEPR: method, limit in NDFrame.replace #53492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Deprecate
mroeschke
reviewed
Jun 6, 2023
| warnings.warn( | ||
| # GH#33302 | ||
| f"The 'method' keyword in {type(self).__name__}.replace is " | ||
| "deprecated and will be removed in a future version.", |
There was a problem hiding this comment.
Is there any way to specify "do X instead"?
There was a problem hiding this comment.
if there are no nans you can do obj.replace(value, np.nan).fillna(method=method), but that messes up with nans. really i think this is just a really weird use case.
There was a problem hiding this comment.
Okay sounds good. Just a merge conflict it appears
mroeschke
reviewed
Jun 13, 2023
|
rebased + green |
mroeschke
approved these changes
Jun 14, 2023
|
Thanks @jbrockmendel |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Jun 15, 2023
* DEPR: method, limit in NDFrame.replace * update test, docs * suppress doctest warning * doctests
mroeschke
added a commit
that referenced
this pull request
Jun 21, 2023
* CI: Build pandas even if doctests fail * BUG: groupby sum turning `inf+inf` and `(-inf)+(-inf)` into `nan` (#53623) * DEPR: method, limit in NDFrame.replace (#53492) * DEPR: method, limit in NDFrame.replace * update test, docs * suppress doctest warning * doctests * PERF: Series.str.get_dummies for ArrowDtype(pa.string()) (#53655) * PERF: Series.str.get_dummies for ArrowDtype(pa.string()) * whatsnew * typing * TYP: core.missing (#53625) * CI: Attempt to fix wheel builds (#53670) * DOC: Fixing EX01 - Added examples (#53647) * SeriesGroupBy.fillna example added * Added examples * Corrected failing test for timedelta.total_seconds * Corrected fillna example * CI/TST: Mark test_to_read_gcs as single_cpu (#53677) * BUG/CoW: is_range_indexer can't handle very large arrays (#53672) * BUG: is_range_indexer can't handle very large arrays * fix test on 32-bit * TST: Use more pytest fixtures --------- Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com> Co-authored-by: jbrockmendel <jbrockmendel@gmail.com> Co-authored-by: Luke Manley <lukemanley@gmail.com> Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com> Co-authored-by: Dea María Léon <deamarialeon@gmail.com>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* DEPR: method, limit in NDFrame.replace * update test, docs * suppress doctest warning * doctests
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* CI: Build pandas even if doctests fail * BUG: groupby sum turning `inf+inf` and `(-inf)+(-inf)` into `nan` (pandas-dev#53623) * DEPR: method, limit in NDFrame.replace (pandas-dev#53492) * DEPR: method, limit in NDFrame.replace * update test, docs * suppress doctest warning * doctests * PERF: Series.str.get_dummies for ArrowDtype(pa.string()) (pandas-dev#53655) * PERF: Series.str.get_dummies for ArrowDtype(pa.string()) * whatsnew * typing * TYP: core.missing (pandas-dev#53625) * CI: Attempt to fix wheel builds (pandas-dev#53670) * DOC: Fixing EX01 - Added examples (pandas-dev#53647) * SeriesGroupBy.fillna example added * Added examples * Corrected failing test for timedelta.total_seconds * Corrected fillna example * CI/TST: Mark test_to_read_gcs as single_cpu (pandas-dev#53677) * BUG/CoW: is_range_indexer can't handle very large arrays (pandas-dev#53672) * BUG: is_range_indexer can't handle very large arrays * fix test on 32-bit * TST: Use more pytest fixtures --------- Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com> Co-authored-by: jbrockmendel <jbrockmendel@gmail.com> Co-authored-by: Luke Manley <lukemanley@gmail.com> Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com> Co-authored-by: Dea María Léon <deamarialeon@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.xref #33302