DEPR: deprecate unit parameters ’T’, 't', 'L', and 'l' #53557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbrockmendel, could you please take a look at this pr? |
natmokval
changed the title
MarcoGorelli
reviewed
Jun 9, 2023
pandas/core/tools/timedeltas.py
Outdated
| @@ -181,6 +181,9 @@ def to_timedelta( | |||
| "represent unambiguous timedelta values durations." | |||
| ) | |||
|
|
|||
| if unit in {"t", "T", "l", "L"}: | |||
| raise ValueError("Units 't', 'T', 'l' and 'L' are no longer supported.") | |||
There was a problem hiding this comment.
Thanks for working on this - there should probably be a FutureWarning first, and then in version 3.0 these units can raise
There was a problem hiding this comment.
Thanks for the comment. I’ll replace raising ValueError with FutureWarning.
|
along with these i think we need to track down other places where we use/allow these codes. _attrname_to_abbrevs/_abbrev_to_attrnames and Tick._prefix come to mind. Doesn't need to be this PR, but hopefully a follow-on |
natmokval
force-pushed
the
BUG-incorrect-unit-validation-for-T
branch
from
b089fa0 to
d2a673f
Compare
MarcoGorelli
approved these changes
Jun 19, 2023
|
Thank you @MarcoGorelli for reviewing this pr. |
|
merging then, thanks! |
canthonyscott
pushed a commit
to canthonyscott/pandas-anthony
that referenced
this pull request
Jun 23, 2023
) * BUG: add ’T’ to UnitChoices to fix incorrect unit validation in to_timedelta() * deprecate units T, t, L, l and fix tests * raise FutureWarning instead of ValueError * correct the to_timedelta definition and add a test for the warning --------- Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
) * BUG: add ’T’ to UnitChoices to fix incorrect unit validation in to_timedelta() * deprecate units T, t, L, l and fix tests * raise FutureWarning instead of ValueError * correct the to_timedelta definition and add a test for the warning --------- Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
|
Why do this? This is a pain in the ass for people |
looks like it comes from here |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added upper case ’T’ for minutes in
UnitChoiceslist. Now mypy doesn’t raise an error.Update:
Deprecated unit parameters ’T’, 't', 'L', 'l', and fixed test.