Skip to content

DEPR: downcast keyword #53671

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Jun 29, 2023
Merged

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel requested a review from rhshadrach as a code owner June 14, 2023 17:21
@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Jun 14, 2023
"downcast other than None, False, and 'infer' are deprecated "
"and will raise in a future version",
f"The 'downcast' keyword in {method_name} is deprecated and "
"will be removed in a future version.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we suggest using to_numeric(downcast) here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, will update

@mroeschke mroeschke added this to the 2.1 milestone Jun 28, 2023
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merge when ready @rhshadrach

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Dtype Conversions Unexpected or buggy dtype conversions labels Jun 29, 2023
@rhshadrach rhshadrach merged commit 0efcad2 into pandas-dev:main Jun 29, 2023
@rhshadrach
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-downcast-kwd branch June 29, 2023 01:29
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: Deprecate downcast keyword for fillna
3 participants