Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DEPR: Remove literal string input for read_html #53785

Closed
wants to merge 5 commits into from
Closed

DEPR: Remove literal string input for read_html #53785

wants to merge 5 commits into from

Conversation

rmhowe425
Copy link
Contributor

@rmhowe425 rmhowe425 commented Jun 22, 2023

@rmhowe425 rmhowe425 marked this pull request as draft June 22, 2023 02:19
@mroeschke mroeschke added the IO Data IO issues that don't fit into a more specific label label Jun 22, 2023
@mroeschke
Copy link
Member

Just a heads up, it would probably be easier to review if one PR is opened for one read_* function deprecation

@rmhowe425 rmhowe425 changed the title DEPR: Remove literal string/bytes input from read_excel, read_html, and read_xml DEPR: Remove literal string input for read_html Jun 22, 2023
@rmhowe425
Copy link
Contributor Author

rmhowe425 commented Jun 22, 2023

@mroeschke I was kind of wondering that too...I just went with what was stated in the GH Issue haha 😄

The deprecation logic for read_html should be good to go. I'll re-word the PR and mark it as ready for approval.

@rmhowe425 rmhowe425 marked this pull request as ready for review June 22, 2023 16:30
@rmhowe425
Copy link
Contributor Author

@mroeschke PR ready for inspection

@rmhowe425 rmhowe425 closed this by deleting the head repository Jun 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
IO Data IO issues that don't fit into a more specific label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEPR]: Remove literal string/bytes input from read_excel, read_html, and read_xml
2 participants