DEPR: Replacing builtin and NumPy funcs in agg/apply/transform #53974
Conversation
rhshadrach
added
Deprecate
| func: Callable, | ||
| alias: str, | ||
| ) -> None: | ||
| if alias.startswith("np."): |
There was a problem hiding this comment.
Will this warn correctly is a user passes numpy.sum or builtins.sum?
There was a problem hiding this comment.
Yes - we use lookups in _builtin_table_alias and _cython_table to identify the function the user passes, so it is independent of any binding (e.g numpy.sum vs np.sum). The alias here arises from the values in these two dictionaries, and so must either start with np. or just be the op name (e.g. "sum")
There was a problem hiding this comment.
Ah, but we will report that pandas is using e.g. np.sum regardless of how the user imports NumPy. So the warning will be emitted under the correct circumstances, but the message might not align with how they import. I think the message is still clear though.
There was a problem hiding this comment.
Okay. Yeah I think the message is clear enough despite how the user imports numpy
|
Thanks @rhshadrach |
…s-dev#53974) * DEPR: Replacing builtin and NumPy funcs in agg/apply/transform * mypy fixup
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.