DEPR: Index.format #55439
Merged
DEPR: Index.format #55439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Output-Formatting
attack68
approved these changes
Oct 11, 2023
mroeschke
reviewed
Oct 13, 2023
| @@ -1383,6 +1391,31 @@ def format( | |||
|
|
|||
| return self._format_with_header(header=header, na_rep=na_rep) | |||
|
|
|||
| _default_na_rep = "NaN" | |||
There was a problem hiding this comment.
Is this correct if the data is a masked array with NA?
There was a problem hiding this comment.
ATM Index.format and DTI.format have different defaults for na_rep. Putting this here keeps the same behavior for _format_flat while avoiding the need for overrding the whole method in DTI.
Looks like na_rep is ignored inside format_with_header anyway
There was a problem hiding this comment.
Looks like na_rep is ignored inside format_with_header anyway
That's probably not good, but I guess that can be tackled elsewhere
mroeschke
approved these changes
Oct 13, 2023
|
Thanks @jbrockmendel |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.