Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WEB: Add page about benchmarks #56907

Merged
merged 9 commits into from
Feb 29, 2024

Conversation

datapythonista
Copy link
Member

CC: @DeaMariaLeon @rhshadrach @lithomas1

This is not yet ready, the conbench url provided is not correctly rendering the css, and I need to add all the information about the OVH server, but opening early in case you have any feedback.

@datapythonista datapythonista added Benchmark Performance (ASV) benchmarks Web pandas website labels Jan 16, 2024
@lithomas1
Copy link
Member

Hm, the ASV link for the OVH results seem to be dead add clicking on any of the times for the runs for the conbench results also gets me a 404.

Is this expected?

@DeaMariaLeon
Copy link
Member

The links on the conbench runs don't work either.
Plus if the menu is not available, one cannot give feedback.

The server where I setup conbench is here and it works: http://57.128.112.95:5000/
Adding it to pandas' website caused this problem with css - I'm working on it.
I think I found the reason, but to fix it I will have to take the server down for a bit.

@datapythonista
Copy link
Member Author

Thanks for the heads up @lithomas1. I'm now synching the asv website to /benchmarks/asv/. Hopefully we'll have the conbench site rendering with the css/js soon.

Any other feedback very welcome.

@datapythonista datapythonista marked this pull request as ready for review February 27, 2024 15:58
@datapythonista
Copy link
Member Author

@lithomas1 @rhshadrach any feedback here before I merge? There will surely be follow ups on this, but I think for now it adds value as it is.

@DeaMariaLeon
Copy link
Member

Just to be clear for other people who may read this, regarding:

the conbench url provided is not correctly rendering the css

Actually, conbench does not currently support this kind of URL. It might in the future. Details about this are here: conbench/conbench#1575.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice write up. One potential suggestion, but I'm good as-is.

web/pandas/community/benchmarks.md Show resolved Hide resolved
@lithomas1
Copy link
Member

This LGTM.

Thanks for writing this up.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit 301c5c7 into pandas-dev:main Feb 29, 2024
16 of 18 checks passed
@rhshadrach
Copy link
Member

Thanks @datapythonista

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Benchmark Performance (ASV) benchmarks Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants