-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
WEB: Add page about benchmarks #56907
Conversation
Hm, the ASV link for the OVH results seem to be dead add clicking on any of the times for the runs for the conbench results also gets me a 404. Is this expected? |
The links on the conbench runs don't work either. The server where I setup conbench is here and it works: http://57.128.112.95:5000/ |
Thanks for the heads up @lithomas1. I'm now synching the asv website to /benchmarks/asv/. Hopefully we'll have the conbench site rendering with the css/js soon. Any other feedback very welcome. |
@lithomas1 @rhshadrach any feedback here before I merge? There will surely be follow ups on this, but I think for now it adds value as it is. |
Just to be clear for other people who may read this, regarding:
Actually, conbench does not currently support this kind of URL. It might in the future. Details about this are here: conbench/conbench#1575. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - nice write up. One potential suggestion, but I'm good as-is.
This LGTM. Thanks for writing this up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @datapythonista |
CC: @DeaMariaLeon @rhshadrach @lithomas1
This is not yet ready, the conbench url provided is not correctly rendering the css, and I need to add all the information about the OVH server, but opening early in case you have any feedback.