Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DEPR: concat ignoring all-NA entries #58314

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Copy link
Member

mypy.....................................................................Failed
- hook id: mypy
- duration: 83.98s
- exit code: 1

pandas/core/internals/concat.py:443: error: Incompatible return value type (got "tuple[dtype[Any] | ExtensionDtype, dtype[Any] | ExtensionDtype]", expected "dtype[Any] | ExtensionDtype")  [return-value]
Found 1 error in 1 file (checked 1443 source files)

@mroeschke mroeschke added this to the 3.0 milestone Apr 19, 2024
@mroeschke mroeschke merged commit 2dbfbbe into pandas-dev:main Apr 19, 2024
46 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-concat branch April 24, 2024 18:06
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* DEPR: concat ignoring all-NA entries

* fixup
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants