-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
TST: Remove test_apply_mutate.py #60631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Testing
pandas testing functions or related to the test suite
Groupby
Apply
Apply, Aggregate, Transform, Map
labels
Dec 31, 2024
rhshadrach
commented
Dec 31, 2024
Comment on lines
-57
to
-65
def test_no_mutate_but_looks_like(): | ||
# GH 8467 | ||
# first show's mutation indicator | ||
# second does not, but should yield the same results | ||
df = pd.DataFrame({"key": [1, 1, 1, 2, 2, 2, 3, 3, 3], "value": range(9)}) | ||
|
||
result1 = df.groupby("key", group_keys=True).apply(lambda x: x[:].value) | ||
result2 = df.groupby("key", group_keys=True).apply(lambda x: x.value) | ||
tm.assert_series_equal(result1, result2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this test, it is the same as:
pandas/pandas/tests/groupby/test_apply.py
Lines 230 to 247 in a8a84c8
@pytest.mark.parametrize( | |
"func", | |
[ | |
lambda x: x, | |
lambda x: x[:], | |
lambda x: x.copy(deep=False), | |
lambda x: x.copy(deep=True), | |
], | |
) | |
def test_groupby_apply_identity_maybecopy_index_identical(func): | |
# GH 14927 | |
# Whether the function returns a copy of the input data or not should not | |
# have an impact on the index structure of the result since this is not | |
# transparent to the user | |
df = DataFrame({"g": [1, 2, 2, 2], "a": [1, 2, 3, 4], "b": [5, 6, 7, 8]}) | |
result = df.groupby("g", group_keys=False).apply(func) | |
tm.assert_frame_equal(result, df[["a", "b"]]) |
mroeschke
approved these changes
Dec 31, 2024
Thanks @rhshadrach |
gmcrocetti
pushed a commit
to gmcrocetti/pandas
that referenced
this pull request
Jan 3, 2025
Remove test_apply_mutate.py
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.