Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

BUG: DataFrame._slice doesnt retain metadata #9793

Merged
merged 1 commit into from
Apr 4, 2015
Merged

BUG: DataFrame._slice doesnt retain metadata #9793

merged 1 commit into from
Apr 4, 2015

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Apr 2, 2015

Closes #9776.

@jreback jreback added this to the 0.16.1 milestone Apr 2, 2015
@jreback
Copy link
Contributor

jreback commented Apr 2, 2015

@sinhrks this is gr8.

I suspect there are some more places where this fails (e.g. look in core/indexing.py)

@sinhrks
Copy link
Member Author

sinhrks commented Apr 3, 2015

@jreback I looked through generic.py and indexing.py, and all the _constructor looks have required __finalize__, except for intermediate output purpose.

jreback added a commit that referenced this pull request Apr 4, 2015
@jreback
Merge pull request #9793 from sinhrks/slice_meta
9a5a9d3 
BUG: DataFrame._slice doesnt retain metadata
@jreback jreback merged commit 9a5a9d3 into pandas-dev:master Apr 4, 2015
@jreback
Copy link
Contributor

jreback commented Apr 4, 2015

thanks!

@jreback
Copy link
Contributor

jreback commented Apr 4, 2015

interested in #8572 ?

@sinhrks sinhrks deleted the slice_meta branch April 4, 2015 21:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Design
Projects
None yet
Milestone
0.16.1
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame doesn't hold _metadata when sliced by slice instance
2 participants
@sinhrks @jreback