-
-
Notifications
You must be signed in to change notification settings - Fork 171
Include files filter updates #173
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Use the recursive nature of the filter to build up the correct relative path to images
This improves the usage of include-files.lua filter in combination with the include-code-files.lua
@tarleb Please review |
Thanks, looks good! Can we add a test for this? |
Sure, I can add a test. I will look at it later this week. |
@tarleb I have updated the test and documentation, but the CI fails in math2svg which seems to be unreleated. BTW, awesome work with pandoc, pandoc/latex docker image etc. Use it everyday, highly appreciated. |
Awesome, thanks! I'll look into the math2svg problems. |
It seems that the math2svg problems are caused by changes in the npm ecosystem. It's probably enough to configure a Ubuntu PPA to get a newer node version installed in our testing container. I'll try if that fixes it, and just merge regardless if it doesn't. |
@lmunch : The relative path changes is generally a good idea, but its really bit too intrusive because
This feature needs probably more thoughts: A variant with absolute paths like: ```{.include}
${env:ROOT_DIR}/chapters/A.md
```
 will work if In this way one can still write multimarkdown documents. Or maybe (`-M "includes-relative-to-cwd=true") ```{.include .relative-to-current}
subdir/A.md
```
{.relative-to-current}
 |
I added this feature in #177. |
This patchset keeps the paths to images relative and also improves the usage in combination with the include-code-files.lua filter