Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds events, cross-domain- and geoscience-libraries #54

Merged
merged 15 commits into from
Dec 19, 2024

Conversation

ofk123
Copy link
Contributor

@ofk123 ofk123 commented Nov 16, 2024

Supposed to close #53,
Adds libraries ref #15 , #16

EDIT: Fixed wrong issue number reference above

Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pangeo-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:01pm

@ofk123 ofk123 marked this pull request as ready for review November 16, 2024 11:19
@ofk123
Copy link
Contributor Author

ofk123 commented Nov 16, 2024

Changed the name of folders in "public", from "core-libraries" & "projects", to "crossdomain_libraries" & "geoscience_libraries", so it is more consistent. On second thought I am not sure if that also will change other parts of the code, so let me know if I should revert that..

EDIT: Nevermind, I ended up controlling all references, so it should be okay.

@maxrjones
Copy link
Member

thanks, and sorry for my slow reply! I'll take a look at this by the end of the week

@maxrjones maxrjones self-requested a review November 20, 2024 15:54
@ofk123 ofk123 mentioned this pull request Nov 26, 2024
@tinaok
Copy link

tinaok commented Nov 27, 2024

@annefou Do we put https://github.com/ofk123/pangeo.io/blob/main/src/events/egu-2025_ESSI_3_2/index.md
under pangeo events in pangeo.io ?

@ofk123
Copy link
Contributor Author

ofk123 commented Dec 6, 2024

Hi @maxrjones, did you find time to have a look? I will be able to make changes if necessary.

@maxrjones
Copy link
Member

Hi @maxrjones, did you find time to have a look? I will be able to make changes if necessary.

Hi @ofk123, I'm deeply sorry for my lack of response here. I got totally swamped with AGU prep and family obligations. I'll have time to take a look tomorrow.

Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @ofk123! I made some minor suggestions. I think we'll likely want to move the ecosystem icons to a dedicated page or implement scrolling, but that done afterwards.

ofk123 and others added 2 commits December 19, 2024 06:28
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
ofk123 and others added 2 commits December 19, 2024 06:35
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
@maxrjones maxrjones merged commit 20bfbd3 into pangeo-data:main Dec 19, 2024
1 check passed
@maxrjones
Copy link
Member

Thanks again @ofk123!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pangeo EGU sessions / short course as events
3 participants