Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

[EI-60] Composer update #12

Merged
merged 1 commit into from
Feb 28, 2022
Merged

[EI-60] Composer update #12

merged 1 commit into from
Feb 28, 2022

Conversation

jspellman814
Copy link
Contributor

@jspellman814 jspellman814 commented Feb 25, 2022

Updated pantheon-systems/pantheon-edge-integrations and pantheon-systems/pantheon-wordpress-edge-integrations, removed openeuropa/composer-artifacts.

Once this change is merged, we'll need to update the composer.json file in wp13n.

@jspellman814 jspellman814 marked this pull request as draft February 25, 2022 17:37
@jspellman814 jspellman814 force-pushed the ei-60-remove-artifact-plugin branch from 88c92f7 to e3d9408 Compare February 25, 2022 18:49
@jspellman814 jspellman814 marked this pull request as ready for review February 25, 2022 18:50
Copy link
Collaborator

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the impact of removing that composer artifacts package? We're still able to get the build files because releases are coming from the build branch, correct?

@jspellman814
Copy link
Contributor Author

What is the impact of removing that composer artifacts package? We're still able to get the build files because releases are coming from the build branch, correct?

Yeah exactly. All files you see here are in the Source code zip for the latest couple releases.

@jspellman814 jspellman814 merged commit 12e5434 into main Feb 28, 2022
@jazzsequence jazzsequence deleted the ei-60-remove-artifact-plugin branch March 1, 2022 16:04
@jazzsequence
Copy link
Collaborator

All files you see here are in the Source code zip for the latest couple releases.

🤔 Interesting, the assets.js and assets.min.js appear to be the same...

https://github.com/pantheon-systems/pantheon-wordpress-edge-integrations/blob/build/dist/js/assets.js

https://github.com/pantheon-systems/pantheon-wordpress-edge-integrations/blob/build/dist/js/assets.min.js

Guess I'll open a bug ticket

@jazzsequence
Copy link
Collaborator

https://getpantheon.atlassian.net/browse/EI-73

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants