Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix plugin compatibility check logic #81

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix plugin compatibility check logic #81

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5b2e10
fix plugin_compatibility array key check
jazzsequence Feb 18, 2025
937465f
pass $plugin_compatibility into the anonymous function
jazzsequence Feb 18, 2025
f170412
move the plugin compatibility check inside the foreach
jazzsequence Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions inc/site-health.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,16 @@ function output_compatibility_status_table( $plugins, $output = true, $incompati
<tbody>
<?php

// Filter out incompatible plugins. This allows us to re-use the status table for different types of compatibility issues.
if ( $incompatible && ( ! isset( $plugins['plugin_compatibility'] ) || $plugins['plugin_compatibility'] !== 'incompatible' ) ) {
$plugins = array_filter( $plugins, function ( $plugins ) {
return $plugins['plugin_compatibility'] === 'incompatible';
} );
}
foreach ( $plugins as $plugin => $field ) {
// Filter out incompatible plugins. This allows us to re-use the status table for different types of compatibility issues.
$plugin_compatibility = isset( $plugin['plugin_compatibility'] ) ? $plugin['plugin_compatibility'] : false;
// var_dump( $plugin_compatibility, wp_list_pluck( $plugins, 'plugin_compatibility' ) );
if ( $incompatible && ( ! $plugin_compatibility || $plugin_compatibility !== 'incompatible' ) ) {
$plugins = array_filter( $plugins, function ( $plugin_compatibility ) {
return $plugin_compatibility === 'incompatible';
} );
}

foreach ( $plugins as $field ) {
/* translators: %s: A plugin's compatibility status. */
$status = sprintf( __( '%s', 'pantheon' ), ucfirst( $field['plugin_status'] ) );
/* translators: %s: A plugin's compatibility status message. */
Expand Down
Loading