Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

new and improved Notion rules for demo #1039

Merged
merged 2 commits into from
Jan 16, 2024
Merged

new and improved Notion rules for demo #1039

merged 2 commits into from
Jan 16, 2024

Conversation

arielkr256
Copy link
Contributor

Background

Found some gaps while working on Notion detection demo

Changes

  • 2 new rules, and several minor improvements to others

Testing

  • make fmt, make lint, make test

@arielkr256 arielkr256 requested review from a team December 13, 2023 18:22
egibs
egibs approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@egibs egibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@egibs egibs merged commit 0e5f0b8 into main Jan 16, 2024
5 checks passed
@egibs egibs deleted the notion-updates branch January 16, 2024 16:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@egibs egibs egibs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielkr256 @egibs