Handle form object being false
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasper
force-pushed
the
method-errors-form-object-false
branch
from
9764a6a to
517cfce
Compare
nicolas-brousse
approved these changes
Oct 8, 2024
|
Thank you @mcasper |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of rails 7.2 a form's object defaults to
falserather thannil, breaking any of the methods in this library that eventually callobject_errors. This change expandsobject_errorsto handle the new default value forobject, returningnilas one would expect.Rails PR reference: rails/rails#49943