-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for Rails 8.0 #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlipper
force-pushed
the
rails-8-support
branch
2 times, most recently
from
November 8, 2024 17:16
79062b7
to
610396e
Compare
Spone
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Ah, Rails 8 requires Ruby 3.3+. I'll update the CI workflow to match. Sorry about that! |
phlipper
force-pushed
the
rails-8-support
branch
from
November 8, 2024 20:14
610396e
to
774b00c
Compare
The CI workflow has been updated to support Rails 8 properly. Sorry about that! |
Spone
reviewed
Nov 8, 2024
* Update `Appraisals` * Update `.github/workflows/main.yml` * Create `rails_8.0_vc_2.0.gemfile` * Create `rails_8.0_vc_3.0.gemfile` * Update `view_component-form.gemspec` * Add a new CHANGELOG entry
Rails 8+ requires Ruby 3.3+.
phlipper
force-pushed
the
rails-8-support
branch
from
November 8, 2024 21:49
61a22fb
to
64a85d8
Compare
Awesome, thanks for your PR @phlipper :) |
Is there an ETA for releasing a new version with this change ? Thanks! |
v0.2.9 released 😊 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for Rails 8.0 which has been officially released: https://rubyonrails.org/2024/11/7/rails-8-no-paas-required.
Notes
Appraisals
Thank you for all of your great work on this gem!