Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve descriptions of the process executions for PEX_PATH composition. #12736

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Sep 1, 2021

Followup to #12675 to improve the process descriptions surrounding PEX_PATH composition.

This only meaningfully affects the output when lockfiles / constraints-file are in use. Afterwards, the output in that case looks like:

$ ./pants --no-process-execution-local-cache --no-remote-cache-read test src/python/pants/util/::
16:20:12.69 [INFO] Completed: Building requirements.pex
16:20:33.47 [INFO] Completed: Resolving pytest.pex from 3rdparty/python/lockfiles/pytest.txt
16:20:36.88 [INFO] Completed: Resolving 3rdparty/python/lockfiles/user_reqs.txt
16:20:38.05 [INFO] Completed: Building pytest_runner.pex
16:20:41.32 [INFO] Completed: test - src/python/pants/util/osutil_test.py:tests succeeded.
16:20:41.96 [INFO] Completed: test - src/python/pants/util/filtering_test.py:tests succeeded.
16:20:41.96 [INFO] Completed: test - src/python/pants/util/eval_test.py:tests succeeded.
16:20:41.97 [INFO] Completed: test - src/python/pants/util/socket_test.py:tests succeeded.
16:20:42.70 [INFO] Completed: Extracting ansicolors==1.1.8 from lockfile.pex
16:20:42.72 [INFO] Completed: Extracting typing-extensions==3.7.4.3 from lockfile.pex
16:20:42.85 [INFO] Completed: Extracting packaging==21.0 from lockfile.pex
16:20:44.56 [INFO] Completed: test - src/python/pants/util/memo_test.py:tests succeeded.
16:20:44.65 [INFO] Completed: test - src/python/pants/util/enums_test.py:tests succeeded.
16:20:44.70 [INFO] Completed: Extracting pytest<6.3,>=6.0.1 from lockfile.pex
16:20:46.86 [INFO] Completed: Composing 2 requirements to build requirements.pex from lockfile.pex
16:20:47.04 [INFO] Completed: Composing 1 requirement to build requirements.pex from lockfile.pex
16:20:48.48 [INFO] Completed: Composing 1 requirement to build requirements.pex from lockfile.pex
16:20:53.01 [INFO] Completed: Building pytest_runner.pex
16:20:53.04 [INFO] Completed: Building pytest_runner.pex
16:20:55.50 [INFO] Completed: test - src/python/pants/util/docutil_test.py:tests succeeded.
16:20:55.73 [INFO] Completed: Building pytest_runner.pex
16:20:56.09 [INFO] Completed: test - src/python/pants/util/contextutil_test.py:tests succeeded.
16:20:56.09 [INFO] Completed: test - src/python/pants/util/dirutil_test.py:tests succeeded.
16:20:58.00 [INFO] Completed: test - src/python/pants/util/collections_test.py:tests succeeded.
16:20:58.27 [INFO] Completed: test - src/python/pants/util/meta_test.py:tests succeeded.
16:20:58.45 [INFO] Completed: test - src/python/pants/util/frozendict_test.py:tests succeeded.
16:20:58.52 [INFO] Completed: test - src/python/pants/util/strutil_test.py:tests succeeded.
16:20:58.56 [INFO] Completed: test - src/python/pants/util/ordered_set_test.py:tests succeeded.

✓ src/python/pants/util/collections_test.py:tests succeeded.
✓ src/python/pants/util/contextutil_test.py:tests succeeded.
✓ src/python/pants/util/dirutil_test.py:tests succeeded.
✓ src/python/pants/util/docutil_test.py:tests succeeded.
✓ src/python/pants/util/enums_test.py:tests succeeded.
✓ src/python/pants/util/eval_test.py:tests succeeded.
✓ src/python/pants/util/filtering_test.py:tests succeeded.
✓ src/python/pants/util/frozendict_test.py:tests succeeded.
✓ src/python/pants/util/memo_test.py:tests succeeded.
✓ src/python/pants/util/meta_test.py:tests succeeded.
✓ src/python/pants/util/ordered_set_test.py:tests succeeded.
✓ src/python/pants/util/osutil_test.py:tests succeeded.
✓ src/python/pants/util/socket_test.py:tests succeeded.
✓ src/python/pants/util/strutil_test.py:tests succeeded.

[ci skip-rust]
[ci skip-build-wheels]

@stuhood stuhood added this to the 2.7.x milestone Sep 1, 2021
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@stuhood
Copy link
Member Author

stuhood commented Sep 1, 2021

@jsirois : I'm going to continue reviewing/running-the-numbers on pex-tool/pex#1431 tonight, but will pipeline landing this in case we continue on the current path.

@stuhood stuhood enabled auto-merge (squash) September 1, 2021 23:52
@stuhood stuhood merged commit 10ed875 into pantsbuild:main Sep 1, 2021
@stuhood stuhood deleted the stuhood/component-pex-ux branch September 2, 2021 00:01
stuhood added a commit to stuhood/pants that referenced this pull request Sep 2, 2021
…on. (pantsbuild#12736)

Followup to pantsbuild#12675 to improve the process descriptions surrounding PEX_PATH composition.

This only meaningfully affects the output when lockfiles / constraints-file are in use. Afterwards, the output in that case looks like:
```
$ ./pants --no-process-execution-local-cache --no-remote-cache-read test src/python/pants/util/::
16:20:12.69 [INFO] Completed: Building requirements.pex
16:20:33.47 [INFO] Completed: Resolving pytest.pex from 3rdparty/python/lockfiles/pytest.txt
16:20:36.88 [INFO] Completed: Resolving 3rdparty/python/lockfiles/user_reqs.txt
16:20:38.05 [INFO] Completed: Building pytest_runner.pex
16:20:41.32 [INFO] Completed: test - src/python/pants/util/osutil_test.py:tests succeeded.
16:20:41.96 [INFO] Completed: test - src/python/pants/util/filtering_test.py:tests succeeded.
16:20:41.96 [INFO] Completed: test - src/python/pants/util/eval_test.py:tests succeeded.
16:20:41.97 [INFO] Completed: test - src/python/pants/util/socket_test.py:tests succeeded.
16:20:42.70 [INFO] Completed: Extracting ansicolors==1.1.8 from lockfile.pex
16:20:42.72 [INFO] Completed: Extracting typing-extensions==3.7.4.3 from lockfile.pex
16:20:42.85 [INFO] Completed: Extracting packaging==21.0 from lockfile.pex
16:20:44.56 [INFO] Completed: test - src/python/pants/util/memo_test.py:tests succeeded.
16:20:44.65 [INFO] Completed: test - src/python/pants/util/enums_test.py:tests succeeded.
16:20:44.70 [INFO] Completed: Extracting pytest<6.3,>=6.0.1 from lockfile.pex
16:20:46.86 [INFO] Completed: Composing 2 requirements to build requirements.pex from lockfile.pex
16:20:47.04 [INFO] Completed: Composing 1 requirement to build requirements.pex from lockfile.pex
16:20:48.48 [INFO] Completed: Composing 1 requirement to build requirements.pex from lockfile.pex
16:20:53.01 [INFO] Completed: Building pytest_runner.pex
16:20:53.04 [INFO] Completed: Building pytest_runner.pex
16:20:55.50 [INFO] Completed: test - src/python/pants/util/docutil_test.py:tests succeeded.
16:20:55.73 [INFO] Completed: Building pytest_runner.pex
16:20:56.09 [INFO] Completed: test - src/python/pants/util/contextutil_test.py:tests succeeded.
16:20:56.09 [INFO] Completed: test - src/python/pants/util/dirutil_test.py:tests succeeded.
16:20:58.00 [INFO] Completed: test - src/python/pants/util/collections_test.py:tests succeeded.
16:20:58.27 [INFO] Completed: test - src/python/pants/util/meta_test.py:tests succeeded.
16:20:58.45 [INFO] Completed: test - src/python/pants/util/frozendict_test.py:tests succeeded.
16:20:58.52 [INFO] Completed: test - src/python/pants/util/strutil_test.py:tests succeeded.
16:20:58.56 [INFO] Completed: test - src/python/pants/util/ordered_set_test.py:tests succeeded.

✓ src/python/pants/util/collections_test.py:tests succeeded.
✓ src/python/pants/util/contextutil_test.py:tests succeeded.
✓ src/python/pants/util/dirutil_test.py:tests succeeded.
✓ src/python/pants/util/docutil_test.py:tests succeeded.
✓ src/python/pants/util/enums_test.py:tests succeeded.
✓ src/python/pants/util/eval_test.py:tests succeeded.
✓ src/python/pants/util/filtering_test.py:tests succeeded.
✓ src/python/pants/util/frozendict_test.py:tests succeeded.
✓ src/python/pants/util/memo_test.py:tests succeeded.
✓ src/python/pants/util/meta_test.py:tests succeeded.
✓ src/python/pants/util/ordered_set_test.py:tests succeeded.
✓ src/python/pants/util/osutil_test.py:tests succeeded.
✓ src/python/pants/util/socket_test.py:tests succeeded.
✓ src/python/pants/util/strutil_test.py:tests succeeded.
```

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit that referenced this pull request Sep 2, 2021
…on. (cherrypick of #12736) (#12737)

Followup to #12675 to improve the process descriptions surrounding PEX_PATH composition.

This only meaningfully affects the output when lockfiles / constraints-file are in use. Afterwards, the output in that case looks like:
```console
$ ./pants --no-process-execution-local-cache --no-remote-cache-read test src/python/pants/util/::
16:20:12.69 [INFO] Completed: Building requirements.pex
16:20:33.47 [INFO] Completed: Resolving pytest.pex from 3rdparty/python/lockfiles/pytest.txt
16:20:36.88 [INFO] Completed: Resolving 3rdparty/python/lockfiles/user_reqs.txt
16:20:38.05 [INFO] Completed: Building pytest_runner.pex
16:20:41.32 [INFO] Completed: test - src/python/pants/util/osutil_test.py:tests succeeded.
16:20:41.96 [INFO] Completed: test - src/python/pants/util/filtering_test.py:tests succeeded.
16:20:41.96 [INFO] Completed: test - src/python/pants/util/eval_test.py:tests succeeded.
16:20:41.97 [INFO] Completed: test - src/python/pants/util/socket_test.py:tests succeeded.
16:20:42.70 [INFO] Completed: Extracting ansicolors==1.1.8 from lockfile.pex
16:20:42.72 [INFO] Completed: Extracting typing-extensions==3.7.4.3 from lockfile.pex
16:20:42.85 [INFO] Completed: Extracting packaging==21.0 from lockfile.pex
16:20:44.56 [INFO] Completed: test - src/python/pants/util/memo_test.py:tests succeeded.
16:20:44.65 [INFO] Completed: test - src/python/pants/util/enums_test.py:tests succeeded.
16:20:44.70 [INFO] Completed: Extracting pytest<6.3,>=6.0.1 from lockfile.pex
16:20:46.86 [INFO] Completed: Composing 2 requirements to build requirements.pex from lockfile.pex
16:20:47.04 [INFO] Completed: Composing 1 requirement to build requirements.pex from lockfile.pex
16:20:48.48 [INFO] Completed: Composing 1 requirement to build requirements.pex from lockfile.pex
16:20:53.01 [INFO] Completed: Building pytest_runner.pex
16:20:53.04 [INFO] Completed: Building pytest_runner.pex
16:20:55.50 [INFO] Completed: test - src/python/pants/util/docutil_test.py:tests succeeded.
16:20:55.73 [INFO] Completed: Building pytest_runner.pex
16:20:56.09 [INFO] Completed: test - src/python/pants/util/contextutil_test.py:tests succeeded.
16:20:56.09 [INFO] Completed: test - src/python/pants/util/dirutil_test.py:tests succeeded.
16:20:58.00 [INFO] Completed: test - src/python/pants/util/collections_test.py:tests succeeded.
16:20:58.27 [INFO] Completed: test - src/python/pants/util/meta_test.py:tests succeeded.
16:20:58.45 [INFO] Completed: test - src/python/pants/util/frozendict_test.py:tests succeeded.
16:20:58.52 [INFO] Completed: test - src/python/pants/util/strutil_test.py:tests succeeded.
16:20:58.56 [INFO] Completed: test - src/python/pants/util/ordered_set_test.py:tests succeeded.

✓ src/python/pants/util/collections_test.py:tests succeeded.
✓ src/python/pants/util/contextutil_test.py:tests succeeded.
✓ src/python/pants/util/dirutil_test.py:tests succeeded.
✓ src/python/pants/util/docutil_test.py:tests succeeded.
✓ src/python/pants/util/enums_test.py:tests succeeded.
✓ src/python/pants/util/eval_test.py:tests succeeded.
✓ src/python/pants/util/filtering_test.py:tests succeeded.
✓ src/python/pants/util/frozendict_test.py:tests succeeded.
✓ src/python/pants/util/memo_test.py:tests succeeded.
✓ src/python/pants/util/meta_test.py:tests succeeded.
✓ src/python/pants/util/ordered_set_test.py:tests succeeded.
✓ src/python/pants/util/osutil_test.py:tests succeeded.
✓ src/python/pants/util/socket_test.py:tests succeeded.
✓ src/python/pants/util/strutil_test.py:tests succeeded.
```

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to jsirois/pants that referenced this pull request Sep 9, 2021
…omposition. (pantsbuild#12736)"

This reverts commit 10ed875.

[ci skip-rust]

[ci skip-build-wheels]
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants