Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump pyzipkin to 0.17.0 #7161

Merged
merged 1 commit into from
Jan 26, 2019
Merged

Conversation

illicitonion
Copy link
Contributor

This supports python 3.7.

This supports python 3.7.
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think we should include this before your release @stuhood, otherwise ./pants3 won't work for Python 3.7 users.

@illicitonion illicitonion merged commit a19a98a into pantsbuild:master Jan 26, 2019
@illicitonion illicitonion deleted the dwagnerhall/pyzipkin branch January 26, 2019 09:19
@stuhood
Copy link
Member

stuhood commented Jan 27, 2019

Great! I think we should include this before your release @stuhood, otherwise ./pants3 won't work for Python 3.7 users.

I just cut #7170, so this made it in.

But to be clear: pants3 is not exposed to end users: only to the pantsbuild/pants repo. End users generally use https://www.pantsbuild.org/install.html#recommended-installation, and so unless we give them a method of creating a Py3 aware pants script (see the curl in that section), they will continue to use Py2.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants