Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(engine): memory overlay hashed storage root #10543

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix(engine): memory overlay hashed storage root #10543

merged 1 commit into from
Aug 26, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Current implementation of MemoryOverlayStateProvider::hashed_storage_root ignores in-memory storage state. Non-critical as it's only used in RPC.

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-consensus Related to the consensus engine labels Aug 26, 2024
@rkrasiuk rkrasiuk requested a review from Rjected August 26, 2024 16:40
@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 498ced8 Aug 26, 2024
35 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/fix-memory-overlay-hashed-storage branch August 26, 2024 18:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @Rjected