Make implicit_provider optional
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
approved these changes
Apr 21, 2020
Comment on lines
+517
to
523
| fn can_provide_crypto(&self) -> Result<ProviderID> { | ||
| match self.implicit_provider { | ||
| ProviderID::Core => Err(Error::Client(ClientErrorKind::InvalidProvider)), | ||
| _ => Ok(()), | ||
| None => Err(Error::Client(ClientErrorKind::NoProvider)), | ||
| Some(ProviderID::Core) => Err(Error::Client(ClientErrorKind::InvalidProvider)), | ||
| Some(crypto_provider) => Ok(crypto_provider), | ||
| } | ||
| } |
src/core/basic_client.rs
Outdated
| /// and it is the responsibility of the user to identify and set an appropriate | ||
| /// one. As such, it is critical that before attempting to use cryptographic | ||
| /// operations users call [`list_providers`](#method.list_providers) | ||
| /// and [`list_provider_operations`](#method.list_provider_operations) |
There was a problem hiding this comment.
Not totally related with this PR but is there a reason why using list_provider_operations instead of list_opcodes?
There was a problem hiding this comment.
I think that sounded more developer-friendly to me at the time, but maybe the low-level one should be named consistently - I'll change
This commit makes the `implicit_provider` optional, allowing the `BasicClient` to start with no such provider. When in this state, core operations are allowed but crypto operations will fail with `NoProvider`. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
force-pushed
the
option-provider
branch
from
a87e0ff to
734d3a3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the
implicit_provideroptional, allowing theBasicClientto start with no such provider. When in this state, coreoperations are allowed but crypto operations will fail with
NoProvider.Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com