Support for ps_sign_ and ps_verify_message Parsec operations. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
hug-dev
approved these changes
May 13, 2021
src/core/basic_client.rs
Outdated
| @@ -722,6 +724,95 @@ impl BasicClient { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// **[Cryptographic Operation]** Create an asymmetric signature on a message. | |||
| /// | |||
| /// The key intended for signing **must** have its `sign_hash` flag set | |||
There was a problem hiding this comment.
Maybe sign_message here? Same for the verify_message
There was a problem hiding this comment.
Corrected - thanks for pointing.
src/core/basic_client.rs
Outdated
| /// of `InvalidProvider` type is returned. | ||
| /// | ||
| /// See the operation-specific response codes returned by the service | ||
| /// [here](https://parallaxsecond.github.io/parsec-book/parsec_client/operations/psa_sign_hash.html#specific-response-status-codes). |
There was a problem hiding this comment.
I guess the link should be https://parallaxsecond.github.io/parsec-book/parsec_client/operations/psa_sign_message.html#specific-response-status-codes
There was a problem hiding this comment.
Corrected - thanks for pointing.
Signed-off-by: Robert Drazkowski <Robert.Drazkowski@globallogic.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo in a working (not yet pushed) copy of Parsec/e2e-tests making sign/verify_message tests always succeeding.
After the typo was corrected, it exposed the problem and below changes fix it.