Changed to use &str for key_name parameters. #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to have to call key_name.clone() when passing it as an argument. Now it follows the pattern of psa_generate_key(&key_name, key_attrs) Issue parallaxsecond#81 Signed-off-by: Matt Davis <matt.davis@arm.com>
ionut-arm
approved these changes
Jul 9, 2021
hug-dev
approved these changes
Jul 12, 2021
Yes, I was thinking of suggesting that as a follow up, until I realized the suffering that would ensue |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to have to call key_name.clone() when passing it as an argument.
Now it follows the pattern of psa_generate_key(&key_name, key_attrs)
Closes #81
Signed-off-by: Matt Davis matt.davis@arm.com