Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added CanDoCrypto to basic client. #93

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

Kakemone
Copy link
Contributor

Added the CanDoCrypto operation to the basic client by adding the can_do_crypto function to the implementation of BasicClient

Signed-off-by: Sam Davis sam.davis@arm.com

@Kakemone
Copy link
Contributor Author

The CI currently fails due to the parsec-interface-rs PR not yet being merged (parallaxsecond/parsec-interface-rs#120).

@Kakemone Kakemone force-pushed the CanDoCrypto_patch branch 3 times, most recently from c539777 to 37cf907 Compare September 13, 2021 13:26
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. A few minor comments. After those fixes and the use of the new interface, should pass the CI and we can merge!

///
/// #Errors
///
/// This operation never return a result but will terminate with Err(Success) or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err(Success) is maybe just Ok(())?

src/core/basic_client.rs Show resolved Hide resolved
Added the CanDoCrypto operation to the basic client by adding the can_do_crypto function to the implementation of BasicClient

Signed-off-by: Sam Davis <sam.davis@arm.com>
@hug-dev hug-dev changed the base branch from main to can-do-crypto September 20, 2021 09:59
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hug-dev hug-dev merged commit 6fbcbfa into parallaxsecond:can-do-crypto Sep 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants