Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add scrutinizer ci support #124

Merged
merged 1 commit into from
Nov 15, 2014
Merged

add scrutinizer ci support #124

merged 1 commit into from
Nov 15, 2014

Conversation

brianium
Copy link
Contributor

Adds support for scrutinizer-ci to paratest. Opts for php_cpd over scrutinizer's php_sim. I have noticed that cpd is more mature and sane about what is considered duplicated code, especially when it comes to things like __call and __get.

Any future tweaks to what we want to track can be added to .scrutinizer.yml

fixes #120

@brianium
Copy link
Contributor Author

@julianseeger am I missing anything here?

@julianseeger
Copy link
Contributor

Erm nope, I think this PR is fine but #123 which I recently merged has broken the tests on the master for hhvm. I couldn't reproduce the failure yet but it must be either fixed or reverted before anything else is merged into the master (like this PR).
It would be nice if you could take a look at the build and see if you can reproduce/fix it.

julianseeger added a commit that referenced this pull request Nov 15, 2014
@julianseeger julianseeger merged commit 1d4ff62 into master Nov 15, 2014
@andreasschroth andreasschroth deleted the enhancement/scrutinizer branch April 12, 2018 09:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

add scrutinizer-ci support
2 participants