Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prove #68 is fixed #495

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Prove #68 is fixed #495

merged 2 commits into from
Aug 4, 2020

Conversation

Slamdunk
Copy link
Member

@Slamdunk Slamdunk commented Aug 4, 2020

Closes #68 #348

@Slamdunk Slamdunk added the bug label Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #495 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #495      +/-   ##
============================================
+ Coverage     92.57%   92.63%   +0.05%     
  Complexity      675      675              
============================================
  Files            34       34              
  Lines          1792     1792              
============================================
+ Hits           1659     1660       +1     
+ Misses          133      132       -1     
Impacted Files Coverage Δ Complexity Δ
src/Runners/PHPUnit/BaseRunner.php 91.52% <0.00%> (+1.69%) 24.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90749b8...4c33493. Read the comment docs.

@Slamdunk Slamdunk merged commit 8316321 into paratestphp:master Aug 4, 2020
@Slamdunk Slamdunk deleted the fix_68 branch August 4, 2020 09:19
@hugochinchilla
Copy link

When can we expect a release containing this fix?

@Slamdunk
Copy link
Member Author

Slamdunk commented Aug 4, 2020

Well, there is no fix here, just a proof that's already fixed.

Btw, there's a lot of refactoring under the hood right now in master, so I'll release it only when it's ready, hopefully with as many bugfixes as possible.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

Successfully merging this pull request may close these issues.

paratest doesn't take the globals in phpunit.xml?
2 participants