Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes electon hmr bug #921

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Fixes electon hmr bug #921

merged 1 commit into from
Mar 2, 2018

Conversation

DeMoorJasper
Copy link
Member

closes #856

@codecov-io
Copy link

Codecov Report

Merging #921 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   89.58%   89.24%   -0.35%     
==========================================
  Files          68       68              
  Lines        3255     3448     +193     
==========================================
+ Hits         2916     3077     +161     
- Misses        339      371      +32
Impacted Files Coverage Δ
src/Bundler.js 92.85% <ø> (ø) ⬆️
src/visitors/fs.js 57.63% <0%> (-22.23%) ⬇️
src/assets/WebManifestAsset.js 59.18% <0%> (-19.39%) ⬇️
src/assets/JSONAsset.js 84.61% <0%> (-8.72%) ⬇️
src/assets/SASSAsset.js 91.48% <0%> (-8.52%) ⬇️
src/assets/LESSAsset.js 93.18% <0%> (-6.82%) ⬇️
src/utils/installPackage.js 61.9% <0%> (-3.18%) ⬇️
src/assets/CSSAsset.js 83.47% <0%> (-2.61%) ⬇️
src/assets/JSAsset.js 91.6% <0%> (-2.3%) ⬇️
src/utils/serializeObject.js 88.23% <0%> (-1.77%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ea515...3f6ff24. Read the comment docs.

@devongovett devongovett merged commit 88630f2 into master Mar 2, 2018
@devongovett devongovett deleted the hmr-hostname-fix branch March 2, 2018 05:52
jkrehm added a commit to highpoint-tech/parcel that referenced this pull request Mar 8, 2018
Fixes regression introduced in parcel-bundler#921
devongovett pushed a commit that referenced this pull request Mar 9, 2018
Fixes regression introduced in #921
devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Fixes regression introduced in #921
devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Fixes regression introduced in #921
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to construct 'WebSocket': The URL 'ws://:61948/' is invalid
3 participants