Desub refactor #42
Merged
Desub refactor #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 6, 2021 19:28
when blocks transition from runtimes, the spec will be `next` but the block extrinsics still use previous spec version
- use index in metadata rather than enumerater() iterator - fix type name sanitization to support <T as Trait<\w>> and <T as Config<\w>>
jsdw
reviewed
Oct 1, 2021
added 4 commits
October 1, 2021 10:04
do_decode is no longer needed since we can inspect the decode length independently.
fix release docs
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
|
As far as the metadata versions go, it might be pertinent to actually add those to Still doing a last run-through of polkadot spec-by-spec ( I think there was one random error i got from the whole chain but i haven't figured out which block it is yet). But once everything is reviewed it should be ready In the future I think |
5 tasks
insipx
added a commit
that referenced
this pull request
Oct 11, 2021
* include hacky legacy metadata (before v12) in desub * add local sp-core and legacy frame-metadata versions directly to desub * using frame-metadata and updating to v14 * Remove StructUnitOrTuple Removal of this struct simplifies `RustTypeMarker`/`SubstrateType` * Make translating from Json to Desub more flexible - Json Objects/arrays/Null fields are seperated based on tuple/struct/enum representation - add better error handling * improve error handling in parse_mod_types * fix decoder test * add more logging and add metadata v13, v14 * rewrote most of modules to make JSON parsing more flexible * typo * implement fallback * start working on tx verifier for entire chains of extrinsics * Desub refactor (#42) * make tx-decoder actual cli app * huge refactoring to consolidate cursor and data states * formatting * clippy * progress, missing an increment somewhere causing signatures to fail decoding * some parts of incrementing the cursor is made clearer by DecodeState * make Extrinsic bytes into an iterator, fix more extrinsics in 1020 * fix bug in Vec decoding * all of 1020 decodes * fix all tests * Decode up to 1050 * fix spec 1062 * 2008 decodes * fix definition for ConsensusEngineId * some upgrades to tx decoder * rework tx-decoder to use previous spec version when blocks transition from runtimes, the spec will be `next` but the block extrinsics still use previous spec version * mutex -> rwlock * fix sanitization, v12 metadata conversion - use index in metadata rather than enumerater() iterator - fix type name sanitization to support <T as Trait<\w>> and <T as Config<\w>> * Add tx_decoder to logs * fix runtimes, number => version * do_decode decides on decode_length independently * remove do_decode in favor of decode do_decode is no longer needed since we can inspect the decode length independently. * fix v12, add v13 metadata * Add bitvec type to `SubstrateTypes` * update v11 to scale-codec 2 * update v9 to scale-codec 2 * update v8 to scale-codec 2 * use one DecodeDifferent from frame-metadata * remove dependency on legacy sp-core * update codec to 2 for extras * Add bitvec type remove not-used version7 metadata * Update core/src/decoder.rs * Update core/src/decoder.rs * some cleanup * Update core/src/decoder.rs * log::error -> println * check for upgrade block 0 * check some * fix santiziation of types with empty generic, <()> * remove all extrinsic integration tests * fix remaining integration tests * fix tests/clippy lints * remove solved todos * add back unused * add test for ChunkedExtrinsic * remove println from test * remove unused RustTypeMarker variant 'String' * remove 'impossible' types * remove more impossible types * fix tests * fix comment * add westend, centrifuge and rococo to FromStr impl * FromStr should allow for custom chains * add docs about upgrade blocks * docs * Update README.md fix release docs * Update README.md * Update bin/tx-decoder/src/queries.rs Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com> * Update bin/tx-decoder/src/queries.rs Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com> * Update bin/tx-decoder/src/queries.rs Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com> * rustfmt * minus v14 for now * add StorageKey definition * add readme comment about StorageKey * choose simplest representations for substrate_types * rusfmt Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com> Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to better control
cursoranddatastates. This should consolidate data and cursor values to make them easily observable and add the possibility of saving states at different points of decoding in order to inspect them and possibly 'rewind' them.Introduces
DecodeStateto the decoderneeded because it will make it much easier to debug extrinsics which don't decode, while making the code easier to read.
Branch off of #41 in case things go south
Versions Passed with 0 Errors on Kusama/Polkadot
Kusama
Polkadot