Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

convert to using frame-metadata crate everywhere #48

Merged
merged 8 commits into from
Oct 22, 2021

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Oct 20, 2021

gets rid of substrate_metadata_versions.

rel paritytech/frame-metadata#27

Not going to be merged until frame metadata releases a version that includes v8-v11, so that we can make the versions in v14 and legacy codepaths the same.

it would be really useful for the facade crate if both core and core_v14 used the same frame-metadata version

@insipx insipx changed the title convert to using frame-metadata crate everywhere [WIP] convert to using frame-metadata crate everywhere Oct 20, 2021
@insipx insipx changed the title [WIP] convert to using frame-metadata crate everywhere convert to using frame-metadata crate everywhere Oct 20, 2021
@insipx insipx requested review from TarikGul, jsdw and dvdplm October 22, 2021 14:38
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cleans up a lot of code, lgtm. 👍

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much nicer, I like it.

@insipx insipx merged commit 1efdd63 into master Oct 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants