Skip to content

Removed AsciiExt import #485

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Removed AsciiExt import #485

merged 2 commits into from
Feb 12, 2018

Conversation

svyatonik
Copy link
Contributor

Found warning in https://travis-ci.org/paritytech/parity-bitcoin/builds/339518985 . Reason: rust-lang/rust#44042 . So there are two options to fix this warning - either to add #[allow(unused_imports)], or to bump up minimal required rustc version. I prefer to require 1.23. If you know any problems with this - please speak now or forever hold your peace :)

@svyatonik svyatonik added M0-build Building and build system. A0-pleasereview Pull request needs code review. labels Feb 12, 2018
Copy link
Contributor

@debris debris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with these changes

@debris debris merged commit 916feb1 into master Feb 12, 2018
@debris debris added A8-looksgood Pull request is reviewed well. and removed A0-pleasereview Pull request needs code review. labels Feb 12, 2018
@debris debris deleted the fix_asciiext branch February 12, 2018 10:12
@5chdn 5chdn added this to the 0.9 milestone Feb 12, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A8-looksgood Pull request is reviewed well. M0-build Building and build system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants