Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(derive): implement size_hint() method for struct and enum #472

Merged
merged 4 commits into from
Jul 14, 2023
Merged

feat(derive): implement size_hint() method for struct and enum #472

merged 4 commits into from
Jul 14, 2023

Conversation

StackOverflowExcept1on
Copy link
Contributor

Resolves #471

bkchr
bkchr approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add some tests.

derive/src/encode.rs Outdated Show resolved Hide resolved
derive/src/encode.rs Show resolved Hide resolved
derive/src/encode.rs Outdated Show resolved Hide resolved
derive/src/encode.rs Show resolved Hide resolved
derive/src/encode.rs Show resolved Hide resolved
@StackOverflowExcept1on
Copy link
Contributor Author

@bkchr it should be fine now, but CI is not working on miri

koute
koute reviewed Jul 7, 2023
View reviewed changes
tests/size_hint.rs Outdated Show resolved Hide resolved
bkchr
bkchr approved these changes Jul 7, 2023
View reviewed changes
tests/size_hint.rs Show resolved Hide resolved
@StackOverflowExcept1on
Copy link
Contributor Author

@koute @ggwpez hi, could you review this PR?

@bkchr
Copy link
Member

bkchr commented Jul 13, 2023

@StackOverflowExcept1on please don't use force pushes!

@ggwpez @koute someone of you could take another look?

koute
koute approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@koute koute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the PR!

@koute koute merged commit 04558a3 into paritytech:master Jul 14, 2023
@StackOverflowExcept1on
Copy link
Contributor Author

@koute how long will it take for the next release with this commit?

@StackOverflowExcept1on StackOverflowExcept1on deleted the derive-size-hint branch July 14, 2023 13:56
@koute
Copy link
Contributor

koute commented Jul 14, 2023

@koute how long will it take for the next release with this commit?

If you can make a PR which bumps the version + updates the changelog I can release it for you.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@koute koute koute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[derive(Encode)] does not implement size_hint() for struct and enum
3 participants
@StackOverflowExcept1on @bkchr @koute