Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use unique encoded generic parameter names in derive #509

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Use unique encoded generic parameter names in derive #509

merged 1 commit into from
Sep 4, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Sep 3, 2023

This ensures that we don't clash with the generic parameter names of the user.

@bkchr
Use unique encoded generic parameter names in derive
81b92fe 
This ensures that we don't clash with the generic parameter names of the user.
koute
koute approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@koute koute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have the rustfmt changes in a separate commit as it's kinda hard to review otherwise. :P (Yeah, we should finally run rustfmt on the whole thing and add a CI job to enforce it.)

@bkchr
Copy link
Member Author

bkchr commented Sep 4, 2023

Yeah sorry, I thought we already had this configured 🙈

@bkchr bkchr merged commit 1516bb9 into master Sep 4, 2023
@bkchr bkchr deleted the bkchr-use-unique-names branch September 4, 2023 05:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@koute koute koute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkchr @koute