Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Core time: Configuration Changes #2268

Closed
1 of 2 tasks
eskimor opened this issue Nov 10, 2023 · 4 comments · Fixed by #3181
Closed
1 of 2 tasks

Core time: Configuration Changes #2268

eskimor opened this issue Nov 10, 2023 · 4 comments · Fixed by #3181
Assignees

Comments

@eskimor
Copy link
Member

eskimor commented Nov 10, 2023

Reconsider whether configurations should even differ (likely not) and then either rename configurations to apply for bulk and on-demand or add new ones for bulk. In particular:

pub max_availability_timeouts: u32,
pub ttl: BlockNumber,

If we settle on having them unified (even with legacy), remove [get_provider_config](https://github.com/paritytech/polkadot-sdk/blob/fc358fdf18c8aff62598cd3e3e072b74e32ba792/polkadot/runtime/parachains/src/assigner.rs#L176) from AssignmentProvider` interface and read configuration directly.

Configurations to change/migrate:

  • Above options as described
  • Rename on_demand_cores configuration to coretime_cores and change meaning to specify how many cores are controlled by coretime. (Will be all eventually.) This configuration will be set by the core time chain via request_core_count.
@eskimor eskimor converted this from a draft issue Nov 10, 2023
@bkchr
Copy link
Member

bkchr commented Nov 10, 2023

  • Rename on_demand_cores configuration to coretime_cores and change meaning to specify how many cores are controlled by coretime. (Will be all eventually.)

Why do we need this config at all? With coretime all the cores will be managed by it. Thus, I don't see any reason for adding a config option for this.

@eskimor
Copy link
Member Author

eskimor commented Nov 14, 2023

It needs to be properly session buffered. An easy way to achieve this, is to simply have it as part of the configuration (which is already session buffered). This is not set in stone though, but it kinda makes sense. It is a configuration after all, just set by the coretime chain.

@eskimor eskimor changed the title New bulk configuration options Core time: New bulk configuration options Nov 15, 2023
@eskimor eskimor changed the title Core time: New bulk configuration options Core time: Configuration Changes Nov 15, 2023
@eskimor eskimor moved this from Backlog to In Progress in parachains team board Dec 21, 2023
@eskimor eskimor self-assigned this Dec 21, 2023
@eskimor eskimor assigned tdimitrov and unassigned eskimor Jan 18, 2024
@eskimor
Copy link
Member Author

eskimor commented Jan 30, 2024

@tdimitrov any updates on this one?

@tdimitrov
Copy link
Contributor

I still haven't started working on this one. I'll do it by tomorrow.

@tdimitrov tdimitrov moved this from In Progress to Review in progress in parachains team board Feb 6, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 29, 2024
…uration` instead (#3181)

This PR removes `AssignmentProviderConfig` and uses the corresponding
ondemand parameters from `HostConfiguration` instead. Additionally
`scheduling_lookahead` and all coretime/ondemand related parameters are
extracted in a separate struct - `SchedulerParams`.

The most relevant commit from the PR is [this
one](830bc0f).

Fixes #2268

---------

Co-authored-by: command-bot <>
@github-project-automation github-project-automation bot moved this from Review in progress to Completed in parachains team board Feb 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Completed
3 participants