-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Core time: Configuration Changes #2268
Comments
Why do we need this config at all? With coretime all the cores will be managed by it. Thus, I don't see any reason for adding a config option for this. |
It needs to be properly session buffered. An easy way to achieve this, is to simply have it as part of the configuration (which is already session buffered). This is not set in stone though, but it kinda makes sense. It is a configuration after all, just set by the coretime chain. |
@tdimitrov any updates on this one? |
I still haven't started working on this one. I'll do it by tomorrow. |
…uration` instead (#3181) This PR removes `AssignmentProviderConfig` and uses the corresponding ondemand parameters from `HostConfiguration` instead. Additionally `scheduling_lookahead` and all coretime/ondemand related parameters are extracted in a separate struct - `SchedulerParams`. The most relevant commit from the PR is [this one](830bc0f). Fixes #2268 --------- Co-authored-by: command-bot <>
Reconsider whether configurations should even differ (likely not) and then either rename configurations to apply for bulk and on-demand or add new ones for bulk. In particular:
If we settle on having them unified (even with legacy), remove
[get_provider_config](https://github.com/paritytech/polkadot-sdk/blob/fc358fdf18c8aff62598cd3e3e072b74e32ba792/polkadot/runtime/parachains/src/assigner.rs#L176) from
AssignmentProvider` interface and read configuration directly.Configurations to change/migrate:
on_demand_cores
configuration tocoretime_cores
and change meaning to specify how many cores are controlled by coretime. (Will be all eventually.) This configuration will be set by the core time chain viarequest_core_count
.The text was updated successfully, but these errors were encountered: