Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[RPC-Spec-V2] Add tests for transactionWatch_unstable_submitAndWatch #3083

Closed
Tracked by #1516
lexnv opened this issue Jan 26, 2024 · 0 comments · Fixed by #3784
Closed
Tracked by #1516

[RPC-Spec-V2] Add tests for transactionWatch_unstable_submitAndWatch #3083

lexnv opened this issue Jan 26, 2024 · 0 comments · Fixed by #3784

Comments

@lexnv
Copy link
Contributor

lexnv commented Jan 26, 2024

The #3079 introduces a test harness for the transaction class.

Extend the tests with various scenarios to validate the behavior of transactionWatch_unstable_submitAndWatch.
The status of the transaction should be correlated with the state of the transaction pool.
A few scenarios ideas:

  • invalid transaction is not included to the chain
  • a valid transaction is included when the transaction pool encounters a test driven ChainEvent::Finalized
  • transaction status advances through Ready, InBlock, Finalized with events driven from the transaction pool

cc @paritytech/subxt-team
@lexnv lexnv mentioned this issue Jan 26, 2024
Open
@lexnv lexnv mentioned this issue Mar 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 9, 2024
@lexnv
rpc-v2/transaction: Generate Invalid events and add tests (#3784)
598e955 
This PR ensures that the transaction API generates an `Invalid` events
for transaction bytes that fail to decode.

The spec mentioned the `Invalid` event at the jsonrpc error section,
however this spec PR makes things clearer:
- paritytech/json-rpc-interface-spec#146

While at it have discovered an inconsistency with the generated events.
The drop event from the transaction pool was incorrectly mapped to the
`invalid` event.

Added tests for the API stabilize the API soon:
- paritytech/json-rpc-interface-spec#144


Closes: #3083


cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc-v2/transaction: Generate Invalid events and add tests paritytech/polkadot-sdk
1 participant
@lexnv