Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

archive: Implement height, hashByHeight and call #1582

Merged
merged 12 commits into from
Sep 28, 2023
Merged

archive: Implement height, hashByHeight and call #1582

merged 12 commits into from
Sep 28, 2023

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Sep 15, 2023

This PR implements:

  • archive_unstable_finalized_height: Get the height of the most recent finalized block
  • archive_unstable_hash_by_height: Get the hashes (possible empty) of blocks from the given height
  • archive_unstable_call: Call into the runtime of a block

Builds on top of: #1560

Testing Done

  • unit tests for the methods with custom block tree for different heights / forks

Closes: #1510
Closes: #1513
Closes: #1511

@paritytech/subxt-team

@lexnv lexnv added A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix I5-enhancement An additional feature request. T3-RPC_API This PR/Issue is related to RPC APIs. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels Sep 15, 2023
@lexnv lexnv self-assigned this Sep 15, 2023
@bkchr bkchr requested a review from skunert September 17, 2023 22:36
Base automatically changed from lexnv/archive_body_genesis to master September 19, 2023 11:29
@lexnv
archive: Implement finalized height
d259a73 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
archive/tests: Test archive_unstable_finalizedHeight
62a1fa0 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
archive: Implement archive_unstable_hashByHeight
c7129d8 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
archive/tests: Test archive_hash_by_height
92f4a1b 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
archive: Implement archive_unstable_call
c9ad16d 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
archive: Simplify call and add tests
1d3d63d 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
archive: Iterate blocks from leaves to finalized
e4f1796 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv force-pushed the lexnv/archive_others branch from 98c4f50 to e4f1796 Compare September 19, 2023 12:34
@lexnv
archive: Map invalid params
c8d2ed3 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
skunert
skunert approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@skunert skunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@lexnv @skunert
Update substrate/client/rpc-spec-v2/src/archive/archive.rs
fca587f 
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
niklasad1
niklasad1 reviewed Sep 20, 2023
View reviewed changes
substrate/client/rpc-spec-v2/src/archive/archive.rs
@@ -83,4 +112,71 @@ where

Ok(Some(hex_string(&header.encode())))
}

fn archive_unstable_finalized_height(&self) -> RpcResult<u32> {
Ok(self.client.info().finalized_number.saturated_into())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's makes sense to throw an error or something if the block number is bigger than u32::MAX instead of truncating....

It might be impossible not sure...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it'd take a few hundred years to hit, but yeah I'd be inlined to at least panic rather than saturate since the latter is hiding some issue :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed this to u64 to be extra safe here :D

jsdw
jsdw approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lexnv
archive: Use u64 instead of u32
3811cd2 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
rpc-spec: Introduce method response struct
21a2048 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
archive/tests: Adjust tests to the new format
5e08f51 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv merged commit 945ebbb into master Sep 28, 2023
@lexnv lexnv deleted the lexnv/archive_others branch September 28, 2023 17:20
ordian added a commit that referenced this pull request Oct 3, 2023
@ordian
Merge branch 'master' into tsv-disabling-node-side
a3bcb2f 
* master: (24 commits)
  Init System Parachain storage versions and add migration check jobs to CI (#1344)
  no-bound derives: Use absolute path for `core` (#1763)
  migrate alliance, fast-unstake and bags list to use derive-impl (#1636)
  Tvl pool staking (#1322)
  improve service error (#1734)
  frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717)
  Point documentation links to monorepo (#1741)
  [NPoS] Fix for Reward Deficit in the pool (#1255)
  Move import queue from `ChainSync` to `SyncingEngine` (#1736)
  Enable mocking contracts (#1331)
  Revert "fix(review-bot): pull secrets from `master` environment" (#1748)
  Remove kusama and polkadot runtime crates (#1731)
  Use `Extensions` to register offchain worker custom extensions (#1719)
  [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666)
  fix(review-bot): pull secrets from `master` environment (#1745)
  Fix `subkey inspect` output text padding (#1744)
  archive: Implement height, hashByHeight and call (#1582)
  rpc/client: Propagate `rpc_methods` method to reported methods (#1713)
  rococo-runtime: `RococoGenesisExt` removed (#1490)
  PVF: more filesystem sandboxing (#1373)
  ...
ordian added a commit that referenced this pull request Oct 10, 2023
@ordian
Merge branch 'tsv-disabling-node-side' into tsv-disabling-backing
863fc7d 
* tsv-disabling-node-side: (24 commits)
  Init System Parachain storage versions and add migration check jobs to CI (#1344)
  no-bound derives: Use absolute path for `core` (#1763)
  migrate alliance, fast-unstake and bags list to use derive-impl (#1636)
  Tvl pool staking (#1322)
  improve service error (#1734)
  frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717)
  Point documentation links to monorepo (#1741)
  [NPoS] Fix for Reward Deficit in the pool (#1255)
  Move import queue from `ChainSync` to `SyncingEngine` (#1736)
  Enable mocking contracts (#1331)
  Revert "fix(review-bot): pull secrets from `master` environment" (#1748)
  Remove kusama and polkadot runtime crates (#1731)
  Use `Extensions` to register offchain worker custom extensions (#1719)
  [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666)
  fix(review-bot): pull secrets from `master` environment (#1745)
  Fix `subkey inspect` output text padding (#1744)
  archive: Implement height, hashByHeight and call (#1582)
  rpc/client: Propagate `rpc_methods` method to reported methods (#1713)
  rococo-runtime: `RococoGenesisExt` removed (#1490)
  PVF: more filesystem sandboxing (#1373)
  ...
@kiltbot kiltbot mentioned this pull request Nov 7, 2023
Closed
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-3-0/4614/1

@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@lexnv @skunert
archive: Implement height, hashByHeight and call (paritytech#1582)
6df3a00 
This PR implements:
- `archive_unstable_finalized_height`: Get the height of the most recent
finalized block
- `archive_unstable_hash_by_height`: Get the hashes (possible empty) of
blocks from the given height
- `archive_unstable_call`: Call into the runtime of a block

Builds on top of: paritytech#1560

### Testing Done
- unit tests for the methods with custom block tree for different
heights / forks

Closes: paritytech#1510
Closes: paritytech#1513
Closes: paritytech#1511

@paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Read extrinsic dispatch result for mined transaction (#1582)
43afa02 
* read extrinsic dispatch result for mined transaction

* commit for the history

* Revert "commit for the history"

This reverts commit 99341b04750639db296172cc1432bd70e458ef4b.

* Revert "read extrinsic dispatch result for mined transaction"

This reverts commit 662b776cbf992be9f1637e52f023b782e8c441d1.

* check for successfult transaction in finality relay

* check for successful transaction in parachains relay

* TrackedTransactionStatus ->TrackedTransactionStatus<HeaderId>

* check for successful transaction in messages relay

* fix compilation

* message_lane_loop_is_able_to_recover_from_unsuccessful_transaction

* fixed too-complex-type clippy error

* aaand compilation
This was referenced Jun 5, 2024
Closed
Closed
@Tbaut Tbaut mentioned this pull request Dec 10, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@niklasad1 niklasad1 niklasad1 left review comments

@jsdw jsdw jsdw approved these changes

@skunert skunert skunert approved these changes

Assignees

@lexnv lexnv

Labels
A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I5-enhancement An additional feature request. T3-RPC_API This PR/Issue is related to RPC APIs.
Projects
None yet
Milestone
No milestone
5 participants
@lexnv @Polkadot-Forum @jsdw @skunert @niklasad1