sudo/sessionKeys: Implement sudo_sessionKeys_unstable_generate #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added
A1-insubstantial
tadeohepperle
approved these changes
Sep 25, 2023
niklasad1
reviewed
Sep 25, 2023
niklasad1
reviewed
Sep 25, 2023
niklasad1
reviewed
Sep 25, 2023
niklasad1
reviewed
Sep 25, 2023
|
@lexnv what is the status here? |
|
I believe I put this on hold for the new Since this PR is already spec-ed out and will add it as If that sounds like a plan, I'll polish this up a bit and ask for some reviews soon 🙏 |
|
Okay 👍 Yeah I will finish the mentioned pr soon. |
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the sudo_sessionKeys_unstable_generate method.
This is basically an equivalent for the
rotate_keysAPI in the RPC-Spec-V2 with extended ability to provide a user-defined seed.The RPC method calls into
SessionKeys_generate_session_keysruntime function.Then, the
SessionKeys_generate_session_keysruntime function generates a series of keys,inserts those keys into the keystore, and returns all the public keys concatenated.
Added a test to validate that keys are propagated to the keystone.
This PR does not expose the
sudo_sessionKeys_unstable_generateto the RPC layer yet, since there might be changes wrt the naming convention.Part of #1516.
@paritytech/subxt-team