Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Publish penpal-runtime crate #1904

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Publish penpal-runtime crate #1904

merged 1 commit into from
Oct 18, 2023

Conversation

NachoPal
Copy link
Contributor

Remove publish = false to publish the crate

@NachoPal NachoPal added the T10-tests This PR/Issue is related to tests. label Oct 17, 2023
@NachoPal NachoPal enabled auto-merge (squash) October 17, 2023 09:47
@NachoPal NachoPal merged commit e73729b into master Oct 18, 2023
@NachoPal NachoPal deleted the nacho/publish-penpal-runtime branch October 18, 2023 06:47
@bkchr
Copy link
Member

bkchr commented Oct 18, 2023

Wait. Why do we publish a test crate?

@NachoPal
Copy link
Contributor Author

Wait. Why do we publish a test crate?

We need it to be used when xcm-emulator integrations tests live outside polkadot-sdk.

penpal-runtime is used to tests system parachains interactions with 3rd party parachains.

@xlc
Copy link
Contributor

xlc commented Oct 19, 2023

why you are testing with test runtime instead of a real runtime? what are you testing?

tdimitrov pushed a commit that referenced this pull request Oct 23, 2023
Remove `publish = false` to publish the crate
@NachoPal
Copy link
Contributor Author

NachoPal commented Nov 2, 2023

why you are testing with test runtime instead of a real runtime? what are you testing?

Penpal simulates a non-system parachain. Right now it is still a pretty dummy runtime and we just use as recipient of XCM messages. Plan is to improve it to be able to properly handle the received assets.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants