-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move migrations to versioned tuples #2030
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Oct 25, 2023
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
…itytech/polkadot-sdk into wk-231025-version-migrations
The CI pipeline was cancelled due to failure one of the required jobs. |
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* submit lane unblock transactions from relay * moved body of select_nonces_to_deliver to the separate select_race_action * extracted latest_confirmed_nonce_at_source method * return Option<RaceAction> from select_race_action * make required_source_header_at_target async * remove extra argument from required_source_header_at_target * small fixes in tests * Revert "return Option<RaceAction> from select_race_action" This reverts commit 9f13dbfae39a5a45564550e8c89b10a524a68729. * implement required_source_header_at_target using what-if approach * fix compilation * fmt * clippy * moved some code to the can_submit_transaction_with
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Description
Follow up of the work started in paritytech/polkadot#7168 by @ggwpez.
This PR moves all current migrations to versioned tuples.
It allows bringing all runtimes from the SDK repo into a compliant state similar to Polkadot and Kusama.
The introduction of
migrations::V1_04_00
migrations::V1_05_00
was not fully required yet but was introduced as placeholder to get things started for the next release after the PR is merged.When v1.5.0 will be released, all
Unreleased
migrations can move tomigrations::V1_05_00
and free the room in the now emptymigrations::Unreleased
for the next version.Check
The PR introduces a new CI check for the formatting of the migrations.
fmt
This PR introduces a few
#[rustfmt::skip]
to prevent theMigrations
from being reformatted to stress on the importance of the migrations' ordering.Checklist
T
required)