Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: fixed std wasm build of xcm #2535

Merged
merged 9 commits into from
Dec 5, 2023
Merged

chore: fixed std wasm build of xcm #2535

merged 9 commits into from
Dec 5, 2023

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Nov 28, 2023 •
edited
Loading

Description

just ensures

cargo check --package staging-xcm  --no-default-features  --target wasm32-unknown-unknown --features=std

work (for CosmWasm)

Checklist

  • My PR includes a detailed description as outlined in the "Description" section above
  • My PR follows the labeling requirements of this project (at minimum one label for T
    required)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 28, 2023 22:34
bkchr
bkchr approved these changes Nov 29, 2023
View reviewed changes
@dzmitry-lahoda @bkchr
Update substrate/primitives/weights/Cargo.toml
ddd784b 
Co-authored-by: Bastian Köcher <git@kchr.de>
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Nov 29, 2023
@bkchr
Copy link
Member

bkchr commented Nov 29, 2023

@dzmitry-lahoda it doesn't compile.

@dzmitry-lahoda
Copy link
Contributor Author

I compiled on staging-xcm ok.
So guess some xcm dep does not?
What job to look to see fail?

@dzmitry-lahoda
Copy link
Contributor Author

oh, seeing comment now as comment. just fixing test.

@bkchr
Copy link
Member

bkchr commented Dec 2, 2023

@dzmitry-lahoda please merge master.

@dzmitry-lahoda dzmitry-lahoda requested a review from bkchr December 3, 2023 12:27
@dzmitry-lahoda dzmitry-lahoda mentioned this pull request Dec 5, 2023
Merged
5 tasks
@bkchr bkchr merged commit 0239ced into paritytech:master Dec 5, 2023
ordian added a commit that referenced this pull request Dec 11, 2023
@ordian
Merge branch 'tsv-disabling' into ao-disabling-disputes
80f371e 
* tsv-disabling: (155 commits)
  Fix failing rc-automation GHA (#2648)
  [ci] Return CI_IMAGE variable (#2647)
  Support querying peer reputation (#2392)
  [ci] Update rust to 1.74 (#2545)
  Relax approval requirements on CI files (#2564)
  Added AllSiblingSystemParachains matcher to be used at a parachain level (#2422)
  Improve polkadot sdk docs (#2631)
  Bridges subtree update (#2602)
  pallet-xcm: add new flexible `transfer_assets()` call/extrinsic (#2388)
  [ci] Move rust-features.sh script to .gitlab folder (#2630)
  Bump parity-db from 0.4.10 to 0.4.12 (#2635)
  sp-core: Rename VrfOutput to VrfPreOutput (#2534)
  chore: fix typo (#2596)
  Bump tracing-core from 0.1.31 to 0.1.32 (#2618)
  chore: fixed std wasm build of xcm (#2535)
  Fix PRdoc that have been previously drafted with older schema (#2623)
  Github Workflow migrations (#1574)
  Bridges update subtree (#2625)
  PVF: Add Secure Validator Mode (#2486)
  statement-distribution: Add tests for incoming acknowledgements (#2498)
  ...
ordian added a commit that referenced this pull request Dec 15, 2023
@ordian
Merge branch 'tsv-disabling' into ao-disabling-statement-distribution
9842b9e 
* tsv-disabling: (155 commits)
  Fix failing rc-automation GHA (#2648)
  [ci] Return CI_IMAGE variable (#2647)
  Support querying peer reputation (#2392)
  [ci] Update rust to 1.74 (#2545)
  Relax approval requirements on CI files (#2564)
  Added AllSiblingSystemParachains matcher to be used at a parachain level (#2422)
  Improve polkadot sdk docs (#2631)
  Bridges subtree update (#2602)
  pallet-xcm: add new flexible `transfer_assets()` call/extrinsic (#2388)
  [ci] Move rust-features.sh script to .gitlab folder (#2630)
  Bump parity-db from 0.4.10 to 0.4.12 (#2635)
  sp-core: Rename VrfOutput to VrfPreOutput (#2534)
  chore: fix typo (#2596)
  Bump tracing-core from 0.1.31 to 0.1.32 (#2618)
  chore: fixed std wasm build of xcm (#2535)
  Fix PRdoc that have been previously drafted with older schema (#2623)
  Github Workflow migrations (#1574)
  Bridges update subtree (#2625)
  PVF: Add Secure Validator Mode (#2486)
  statement-distribution: Add tests for incoming acknowledgements (#2498)
  ...
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@dzmitry-lahoda @bkchr
chore: fixed std wasm build of xcm (paritytech#2535)
b29fd37 
# Description

just ensures

```sh
cargo check --package staging-xcm  --no-default-features  --target wasm32-unknown-unknown --features=std
```

work (for CosmWasm)

# Checklist

- [x] My PR includes a detailed description as outlined in the
"Description" section above
- [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process)
of this project (at minimum one label for `T`
  required)
- [x] I have made corresponding changes to the documentation (if
applicable)
- [ ] I have added tests that prove my fix is effective or that my
feature works (if applicable)

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzmitry-lahoda @bkchr @franciscoaguirre @ggwpez