Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FRAME] Consistently use u64 as BlockNumber on FRAME tests #3285

Closed
wants to merge 42 commits into from
Closed

[FRAME] Consistently use u64 as BlockNumber on FRAME tests #3285

wants to merge 42 commits into from

Conversation

philoniare
Copy link
Contributor

Description

Refactors FRAME tests to use u64 as Blocknumber in accordance with the discussion on issue #1657.

Fixes #1657

@philoniare philoniare requested a review from a team as a code owner February 11, 2024 11:46
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Feb 11, 2024

User @philoniare, please sign the CLA here.

@philoniare philoniare requested a review from cheme as a code owner February 11, 2024 18:15
@paritytech-review-bot paritytech-review-bot bot requested review from a team February 11, 2024 18:15
ggwpez
ggwpez reviewed Feb 11, 2024
View reviewed changes
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 12, 2024 01:38
@liamaharon liamaharon added the R0-silent Changes should not be mentioned in any release notes label Feb 12, 2024
@liamaharon
Copy link
Contributor

@philoniare can you please make sure it compiles? (see ci)

@philoniare
Copy link
Contributor Author

@philoniare can you please make sure it compiles? (see ci)

Yep sorry, I'm still working on it. Is there any way to mark a PR as "Not yet ready for review"?

@liamaharon
Copy link
Contributor

Np :) yep

Screenshot 2024-02-12 at 16 39 14

@philoniare
Copy link
Contributor Author

Np :) yep

Screenshot 2024-02-12 at 16 39 14

ah ty!! just what I needed

@philoniare philoniare marked this pull request as draft February 12, 2024 12:42
@philoniare philoniare force-pushed the update-blocknumber-tests branch from d505cbd to 15f8569 Compare February 12, 2024 15:56
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5197564

@philoniare philoniare marked this pull request as ready for review February 13, 2024 15:01
@philoniare
Copy link
Contributor Author

@liamaharon all tests are passing now, except for the westend-runtime, which I was also able to reproduce on the master branch.

@philoniare philoniare requested a review from ggwpez February 14, 2024 02:32
gupnik
gupnik approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@gupnik gupnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gupnik
Copy link
Contributor

gupnik commented Feb 14, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 14, 2024 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5209205 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-7ee39c2e-b283-4ac9-9c8e-d0e76d83dda4 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Feb 14, 2024

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5209205 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5209205/artifacts/download.

@philoniare
Copy link
Contributor Author

Thank you!

Thanks for the guidance 🙏

@philoniare
Copy link
Contributor Author

Closing this as per the discussion on the original issue.

@philoniare philoniare closed this Feb 15, 2024
@Gilt0 Gilt0 mentioned this pull request Feb 20, 2024
Closed
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@gupnik gupnik gupnik approved these changes

@cheme cheme Awaiting requested review from cheme cheme is a code owner

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move all tests to use u32 as BlockNumber
5 participants
@philoniare @liamaharon @paritytech-cicd-pr @gupnik @ggwpez