Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pallet-membership weights #3324

Merged
merged 11 commits into from
Feb 23, 2024

Conversation

Dinonard
Copy link
Contributor

Summary

  • use benchamarked weights instead of hardcoded ones for pallet-membership
  • rename benchmark to match extrinsic name
  • remove unnecessary dependency from clear_prime

@Dinonard Dinonard requested a review from a team as a code owner February 14, 2024 13:08
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😅

@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 14, 2024 15:03
@Dinonard
Copy link
Contributor Author

Can this be merged or is there something else I should do?

@ggwpez ggwpez added R0-silent Changes should not be mentioned in any release notes and removed R0-silent Changes should not be mentioned in any release notes labels Feb 19, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez enabled auto-merge February 19, 2024 18:00
@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Feb 19, 2024
@ggwpez ggwpez added this pull request to the merge queue Feb 23, 2024
Merged via the queue into paritytech:master with commit 5fc6d67 Feb 23, 2024
122 of 129 checks passed
@Dinonard Dinonard deleted the dinonard/pallet-membership-weights branch February 23, 2024 14:33
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
## Summary
* use benchamarked weights instead of hardcoded ones for
`pallet-membership`
* rename benchmark to match extrinsic name
* remove unnecessary dependency from `clear_prime`

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants