Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove recursion limit #3348

Merged
merged 2 commits into from
Feb 16, 2024
Merged

remove recursion limit #3348

merged 2 commits into from
Feb 16, 2024

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Feb 16, 2024

According to the doc, the default is 128, so no point to specify limit with 128

@xlc xlc requested review from a team and koute as code owners February 16, 2024 05:27
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5231207

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5231205

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5231206

@xlc
Copy link
Contributor Author

xlc commented Feb 16, 2024

Is CI broken?

@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Feb 16, 2024
@bkchr bkchr requested a review from ggwpez February 16, 2024 12:01
@bkchr bkchr enabled auto-merge February 16, 2024 12:01
@bkchr bkchr added this pull request to the merge queue Feb 16, 2024
Merged via the queue into paritytech:master with commit 34352e8 Feb 16, 2024
131 of 134 checks passed
@xlc xlc deleted the remove-recursion-limit branch February 16, 2024 19:52
ordian added a commit that referenced this pull request Feb 19, 2024
* master: (41 commits)
  Add Coretime to Westend (#3319)
  removed `pallet::getter` from `pallet-sudo` (#3370)
  gossip-support: add unittests for update authorities (#3258)
  [FRAME Core] remove unnecessary overrides while using derive_impl for frame_system (#3317)
  Update coretime-westend bootnodes (#3380)
  `im-online` removal cleanup: remove off-chain storage (#2290)
  Bump the known_good_semver group with 1 update (#3379)
  Fix documentation dead link (#3372)
  Make `sp-keystore` `no_std`-compatible and fix the `build-runtimes-polkavm` CI job (#3363)
  Remove unused `im-online` weights (#3373)
  Ensure referenda `TracksInfo` is sorted (#3325)
  rpc server: add rate limiting middleware (#3301)
  do not block finality for "disabled" disputes (#3358)
  fix(zombienet): docker `img` version to use in merge queues for bridges (#3337)
  Various nits and alignments for SP testnets found during bumping `polkadot-fellows` repo (#3359)
  Add broker pallet to `coretime-westend` (#3272)
  remove recursion limit (#3348)
  Update subkey README.md (#3355)
  Bump the known_good_semver group with 6 updates (#3347)
  Document LocalKeystore insert method (#3336)
  ...
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
According to the
[doc](https://doc.rust-lang.org/reference/attributes/limits.html), the
default is 128, so no point to specify limit with 128

Co-authored-by: Bastian Köcher <git@kchr.de>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants