Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Contracts upload with Determinism::Enforced when possible #3540

Merged
merged 17 commits into from
Mar 6, 2024
Merged

Contracts upload with Determinism::Enforced when possible #3540

merged 17 commits into from
Mar 6, 2024

Conversation

pgherveou
Copy link
Contributor

No description provided.

@pgherveou pgherveou requested a review from athei as a code owner March 1, 2024 10:53
@pgherveou pgherveou force-pushed the pg/contracts-upload-with-determinism-enforced-when-possible branch from b6ac4c8 to f3ace02 Compare March 1, 2024 15:32
@pgherveou pgherveou added the T7-smart_contracts This PR/Issue is related to smart contracts. label Mar 4, 2024
@pgherveou pgherveou enabled auto-merge March 4, 2024 14:22
xermicus
xermicus reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@xermicus xermicus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall

pgherveou and others added 2 commits March 4, 2024 18:43
@pgherveou @xermicus
Update prdoc/pr_3540.prdoc
1d47da7 
Co-authored-by: Cyrill Leutwiler <cyrill@parity.io>
@pgherveou @xermicus
Update prdoc/pr_3540.prdoc
6191da1 
Co-authored-by: Cyrill Leutwiler <cyrill@parity.io>
@pgherveou
Copy link
Contributor Author

bot help

@command-bot
Copy link

command-bot bot commented Mar 4, 2024

Here's a link to docs

@pgherveou
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_contracts

@command-bot
Copy link

command-bot bot commented Mar 4, 2024 •
edited
Loading

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5431258 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-74c38015-d786-4000-87c3-87540e3da35c to cancel this command or bot cancel to cancel all commands in this pull request.

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
770bd90 
…=dev --target_dir=substrate --pallet=pallet_contracts
@command-bot
Copy link

command-bot bot commented Mar 4, 2024

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5431258 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5431258/artifacts/download.

@pgherveou pgherveou added this pull request to the merge queue Mar 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2024
@athei athei added this pull request to the merge queue Mar 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2024
@athei
Copy link
Member

athei commented Mar 6, 2024

Gotta love those random CI failures.

@athei athei enabled auto-merge March 6, 2024 08:57
@pgherveou pgherveou disabled auto-merge March 6, 2024 13:54
@pgherveou pgherveou enabled auto-merge March 6, 2024 13:54
@pgherveou pgherveou added this pull request to the merge queue Mar 6, 2024
Merged via the queue into master with commit 9952786 Mar 6, 2024
127 of 130 checks passed
@pgherveou pgherveou deleted the pg/contracts-upload-with-determinism-enforced-when-possible branch March 6, 2024 17:13
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@pgherveou @xermicus @athei
Contracts upload with Determinism::Enforced when possible (paritytech…
a2cfbb1 
…#3540)

Co-authored-by: Cyrill Leutwiler <cyrill@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@athei athei athei approved these changes

@xermicus xermicus xermicus approved these changes

Assignees
No one assigned
Labels
T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgherveou @athei @xermicus