Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

collation-generation: Avoid using para_backing_state if runtime is ancient #4070

Merged
merged 8 commits into from
Apr 11, 2024

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Apr 10, 2024

fixes #4067

Also add an early bail out for look ahead collator such that we don't waste time if a CollatorFn is not set.

TODO:

  • add test.
  • Polkadot System Parachain burn-in.

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added R0-silent Changes should not be mentioned in any release notes T9-cumulus This PR/Issue is related to cumulus. labels Apr 10, 2024
@bkchr bkchr removed the R0-silent Changes should not be mentioned in any release notes label Apr 10, 2024
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Copy link
Contributor Author

Asked for a burn-in to confirm the fix. We'll have to do a hotfix release once this is merged/backported.

@PierreBesson
Copy link

PierreBesson commented Apr 10, 2024

The burn-in on Polkadot AssetHub collators confirms that this is fixing the issue of collators not producing blocks.

sandreim and others added 6 commits April 10, 2024 19:33
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added this pull request to the merge queue Apr 11, 2024
Merged via the queue into master with commit 9ede415 Apr 11, 2024
132 of 136 checks passed
@sandreim sandreim deleted the sandreim/properly_check_for_async_backing_runtime branch April 11, 2024 11:00
EgorPopelyaev pushed a commit that referenced this pull request Apr 11, 2024
…ancient (#4070)

fixes #4067

Also add an early bail out for look ahead collator such that we don't
waste time if a CollatorFn is not set.

TODO:
- [x] add test.
- [x] Polkadot System Parachain burn-in.

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polkadot-parachain v1.10.0 breaks collating on polkadot system chains
4 participants